Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52489

"Download all submissions as a zip" don't copy files with same name from the same student and folder structure is lost

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Create a course with multiple students.
      2. Create an assignment with 'File submissions' and 'Feedback files' enabled and set 'Maximum number of uploaded files' to '5'.
      3. Log in as a student.
      4. Add a submission with multiple files (some being text) with different names (include weird characters in file names) and folders (with files inside).
      5. Repeat the above 2 steps with multiple students creating different file structures each time.
      6. Log in as a teacher/admin.
      7. Visit the assignment and click on 'View/grade all submissions'.
      8. Under 'Grading action' select 'Download all submissions'.
      9. Confirm that the zip contains the folder structure you created during submissions and the files have not been renamed.
      Test 2
      1. Using the downloaded zip obtained from the above test change the text file content and add new files.
      2. Log in as a teacher/admin.
      3. Visit the assignment and click on 'View/grade all submissions'.
      4. Under 'Grading action' select 'Upload multiple feedback files in a zip'.
      5. Upload the new zip.
      6. Confirm the feedback left for the students is correct.
      Test 3
      1. Revert the commits for this issue, or checkout another branch w/o these commits (so you are downloading the old file structure).
      2. Visit the assignment and click on 'View/grade all submissions'.
      3. Under 'Grading action' select 'Download all submissions'.
      4. Reintroduce the commits for this issue.
      5. Edit the files in the zip you downloaded in step 1.
      6. Upload the new zip.
      7. Confirm the feedback left for the students is correct.
      Show
      Test 1 Create a course with multiple students. Create an assignment with 'File submissions' and 'Feedback files' enabled and set 'Maximum number of uploaded files' to '5'. Log in as a student. Add a submission with multiple files (some being text) with different names (include weird characters in file names) and folders (with files inside). Repeat the above 2 steps with multiple students creating different file structures each time. Log in as a teacher/admin. Visit the assignment and click on 'View/grade all submissions'. Under 'Grading action' select 'Download all submissions'. Confirm that the zip contains the folder structure you created during submissions and the files have not been renamed. Test 2 Using the downloaded zip obtained from the above test change the text file content and add new files. Log in as a teacher/admin. Visit the assignment and click on 'View/grade all submissions'. Under 'Grading action' select 'Upload multiple feedback files in a zip'. Upload the new zip. Confirm the feedback left for the students is correct. Test 3 Revert the commits for this issue, or checkout another branch w/o these commits (so you are downloading the old file structure). Visit the assignment and click on 'View/grade all submissions'. Under 'Grading action' select 'Download all submissions'. Reintroduce the commits for this issue. Edit the files in the zip you downloaded in step 1. Upload the new zip. Confirm the feedback left for the students is correct.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52489_master

      Description

      1- Create a new assign "files submission" in a course
      2- As a student, add 2 files with the same name, one in the root and another in a folder (See attachment)
      3- As the teacher, "Download all submissions as a zip" in "View/grade all submissions" section. You should only see both files in the folder.

      Currently the mod/assign provides a link to "Download all submissions as a zip", which is great except that all the students' work shows up in the same directory. Instead of using a modified filename to separate students' work it would be better to put each student's work into a separate folder (named with the student's first & last name), and then keep the original file name (and extension) for each file.

      Folder name for each student (for all submission types): "firstname lastname_uniqueiduser"

        Attachments

        1. feedback_files.jpg
          feedback_files.jpg
          33 kB
        2. feedback_files2.jpg
          feedback_files2.jpg
          68 kB
        3. structure_assign.jpg
          structure_assign.jpg
          6 kB
        4. structure_zip_download.jpg
          structure_zip_download.jpg
          34 kB
        5. structure_zip_download2.jpg
          structure_zip_download2.jpg
          62 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 hour
                  1h
                  Remaining:
                  0m
                  Logged:
                  Time Not Required
                  Not Specified