Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52522

grade_minmaxtouse not respected for overridden categories

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisites
      1. A course with a teacher and a two students (I'll call them student A and student B)
      2. Additional grade category aggregation types enabled: "Site administration" > "Grades" > "Grade category settings" > select all the items under "Available aggregation types"
      3. A gradebook with a category item with aggregation set to highest grade.
        • Set this up at "Course administration" > "Gradebook setup". Just enter the name, leave everything else at defaults.
      4. 2 grade items in the grade category. Again, just enter a name, leave everything else at the default setting (except the category, set that to the category you just made).
      Testing

      The following is all done as the teacher:

      1. Navigate to "Course administration" > "Grades", then "Grade administration" > "Single view"
      2. Select student A and award them a grade of 60 for one grade item and 70 for another.
      3. Select student B and award them a grade of 60 for one grade item and 70 for another.
      4. Navigate to "Grade administration" > "User report" and view the report for student A. Verify the their total for the category is 70%
      5. View the report for student B and verify the total for the category is also 70%
      6. Navigate to "Setup" > "Gradebook setup" and edit the grade category.
      7. Under "Category total" verify there is no mention of rescaling.
      8. Change the maximum grade to 150.
      9. Check the user report for student A and student B. Verify they both still have a grade of 70% for the category.
      10. Navigate to "Grade administration" > "Single view" and select student A.
      11. Check the override box for the grade category and award them a grade of 150.
      12. Verify on the user report that student A now has a mark of 100% for the category.
      13. Navigate to "Setup" > "Gradebook setup" and edit the grade category.
      14. Expand the "Category total" section and verify a message is displayed explaining that grades have already been awarded and a decision must be made.
      15. Try to change the min/max without selecting whether to rescale. Verify you get an error.
      16. Choose to rescale the grades, and update the maximum to be 200
      17. View the user report for student A and verify that they still have a mark of 100%
      18. View the user report for student B and verify that they still have a mark of 70%
      19. Change the max for the category to be 300, this time choosing not to rescale.
      20. Check the user report for student A and verify that their mark is still 100% and the rande for the category is still 0-200
      21. Check the user for student B and verify that they have a mark of 70% for the category and the range is 0-300

      Bonus: Repeat the above using different aggregation methods if you want :]

      Show
      Prerequisites A course with a teacher and a two students (I'll call them student A and student B) Additional grade category aggregation types enabled: "Site administration" > "Grades" > "Grade category settings" > select all the items under "Available aggregation types" A gradebook with a category item with aggregation set to highest grade. Set this up at "Course administration" > "Gradebook setup". Just enter the name, leave everything else at defaults. 2 grade items in the grade category. Again, just enter a name, leave everything else at the default setting (except the category, set that to the category you just made). Testing The following is all done as the teacher: Navigate to "Course administration" > "Grades", then "Grade administration" > "Single view" Select student A and award them a grade of 60 for one grade item and 70 for another. Select student B and award them a grade of 60 for one grade item and 70 for another. Navigate to "Grade administration" > "User report" and view the report for student A. Verify the their total for the category is 70% View the report for student B and verify the total for the category is also 70% Navigate to "Setup" > "Gradebook setup" and edit the grade category. Under "Category total" verify there is no mention of rescaling. Change the maximum grade to 150. Check the user report for student A and student B. Verify they both still have a grade of 70% for the category. Navigate to "Grade administration" > "Single view" and select student A. Check the override box for the grade category and award them a grade of 150. Verify on the user report that student A now has a mark of 100% for the category. Navigate to "Setup" > "Gradebook setup" and edit the grade category. Expand the "Category total" section and verify a message is displayed explaining that grades have already been awarded and a decision must be made. Try to change the min/max without selecting whether to rescale. Verify you get an error. Choose to rescale the grades, and update the maximum to be 200 View the user report for student A and verify that they still have a mark of 100% View the user report for student B and verify that they still have a mark of 70% Change the max for the category to be 300, this time choosing not to rescale. Check the user report for student A and verify that their mark is still 100% and the rande for the category is still 0-200 Check the user for student B and verify that they have a mark of 70% for the category and the range is 0-300 Bonus: Repeat the above using different aggregation methods if you want :]
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-52522-master
    • Sprint:
      3.1 Sprint 5
    • Issue size:
      Large

      Description

      If you override a category grade, it should respect the grade_minmaxtouse setting, but it does not. It always processes with the grade_grades max.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                14 Vote for this issue
                Watchers:
                23 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16