Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52597

forum neighbour tests use dirty, nasty, horrible sleep

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9.3, 3.0.1, 3.1
    • 2.9.4, 3.0.2
    • Forum, Unit tests
    • MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MDL-52597-master
    • Hide

      Run unit tests:

      ./vendor/bin/phpunit --filter test_forum_get_neighbours --stop-on-failure
      

      1. Confirm they pass
      2. Confirm that they are faster than they used to be
      Show
      Run unit tests: ./vendor/bin/phpunit --filter test_forum_get_neighbours --stop-on-failure Confirm they pass Confirm that they are faster than they used to be

    Description

      There are currently 35 x 1 second sleeps in the mod_forum tests. Let's kill them and replace them with DB updates which are faster and less fragile.

      Attachments

        Activity

          People

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Rajesh Taneja Rajesh Taneja
            David Monllaó David Monllaó
            Mark Nelson Mark Nelson
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/Jan/16