Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52597

forum neighbour tests use dirty, nasty, horrible sleep

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.3, 3.0.1, 3.1
    • Fix Version/s: 2.9.4, 3.0.2
    • Component/s: Forum, Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      Run unit tests:

      ./vendor/bin/phpunit --filter test_forum_get_neighbours --stop-on-failure
      

      1. Confirm they pass
      2. Confirm that they are faster than they used to be
      Show
      Run unit tests: ./vendor/bin/phpunit --filter test_forum_get_neighbours --stop-on-failure Confirm they pass Confirm that they are faster than they used to be
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-52597-master

      Description

      There are currently 35 x 1 second sleeps in the mod_forum tests. Let's kill them and replace them with DB updates which are faster and less fragile.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Rajesh Taneja
            Integrator:
            David Monllaó
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jan/16