[MDL-52608] Better php coding style in function fullname() in /lib/moodlelib.php - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Check nightly server, make sure that all behats pass

In php5 and php7, make sure no debugging messages display while doing the following:

Create a course and enrol a student

View the participants list

View the student's profile

Create an assignment

View the grading screen
Show
Check nightly server, make sure that all behats pass In php5 and php7, make sure no debugging messages display while doing the following: Create a course and enrol a student View the participants list View the student's profile Create an assignment View the grading screen
Affected Branches:
MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
https://github.com/xow/moodle.git
Pull Master Branch:
~~MDL-52608~~-master
Pull Master Diff URL:
https://github.com/xow/moodle/compare/ef343c3...MDL-52608-master

There is code in /lib/moodlelib.php:3263:

// Get all of the name fields.

    $allnames = get_all_user_name_fields();

    if ($CFG->debugdeveloper) {

        foreach ($allnames as $allname) {

            if (!array_key_exists($allname, $user)) {

                // If all the user name fields are not set in the user object, then notify the programmer that it needs to be fixed.

                debugging('You need to update your sql to include additional name fields in the user object.', DEBUG_DEVELOPER);

                // Message has been sent, no point in sending the message multiple times.

                break;

Problem is in the line 3267:

if (!array_key_exists($allname, $user)) {

$user is stdClass, line can be changed to:

if (!object_property_exists($user, $allname)) {

Participants:: Andrew Nicols, CiBoT, Dmitriy Kuzevanov, John Okely, moodle.com, Rajesh Taneja

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)