Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52666

Add $_SERVER['REQUEST_METHOD'] to performance information

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.1, 3.6
    • Fix Version/s: 3.6
    • Component/s: Performance
    • Labels:
    • Testing Instructions:
      Hide

      1. Add to config.php:

      define('MDL_PERF'  , true);
      define('MDL_PERFTOLOG'  , true);
      

      2. Open login page, log in.
      3. Review web server log file (e.g. apache error log)
      4. Confirm HTTP method is captured in PERF information, e.g.

      [Wed Apr 27 15:11:28.080640 2016] [:error] [pid 6144] [client 127.0.0.1:49748] PERF: /moodle_upstream_bugfix/login/index.php time: 0.015686s method: POST memory_total: 3907280B (3.7MB) memory_growth: 3538976B (3.4MB) memory_peak: 4999640B (4.8MB) includecount: 83 contextswithfilters: 0 filterscreated: 0 textsfiltered: 0 stringsfiltered: 0 langcountgetstring: 14 db reads/writes: 12/2 db queries time: 0.00368s ticks: 1 user: 1 sys: 0 cuser: 0 csys: 0 serverload: 0.70 Session (core\\session\\file): 1.4KB Caches used (hits/misses/sets): core/databasemeta {** static acceleration **(4/5/0) cachestore_file(5/0/0) } core/string {** static acceleration **(12/2/0) cachestore_file(2/0/0) } core/observers {** static acceleration **(0/2/0) cachestore_file(2/0/0) } core/htmlpurifier {cachestore_file(1/0/0) } . , referer: http://tt/moodle_upstream_bugfix/login/index.php
      

      Show
      1. Add to config.php: define('MDL_PERF' , true); define('MDL_PERFTOLOG' , true); 2. Open login page, log in. 3. Review web server log file (e.g. apache error log) 4. Confirm HTTP method is captured in PERF information, e.g. [Wed Apr 27 15:11:28.080640 2016] [:error] [pid 6144] [client 127.0.0.1:49748] PERF: /moodle_upstream_bugfix/login/index.php time: 0.015686s method: POST memory_total: 3907280B (3.7MB) memory_growth: 3538976B (3.4MB) memory_peak: 4999640B (4.8MB) includecount: 83 contextswithfilters: 0 filterscreated: 0 textsfiltered: 0 stringsfiltered: 0 langcountgetstring: 14 db reads/writes: 12/2 db queries time: 0.00368s ticks: 1 user: 1 sys: 0 cuser: 0 csys: 0 serverload: 0.70 Session (core\\session\\file): 1.4KB Caches used (hits/misses/sets): core/databasemeta {** static acceleration **(4/5/0) cachestore_file(5/0/0) } core/string {** static acceleration **(12/2/0) cachestore_file(2/0/0) } core/observers {** static acceleration **(0/2/0) cachestore_file(2/0/0) } core/htmlpurifier {cachestore_file(1/0/0) } . , referer: http://tt/moodle_upstream_bugfix/login/index.php
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      fix/MDL-52666

      Description

      It would be helpful to add $_SERVER['REQUEST_METHOD'] (POST vs GET usually) to the performance information logged when MDL_PERF is defined.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18