Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52672

nouserstobeadded string in auth_ldap.php missing newline character

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.9.3, 3.0.1
    • Fix Version/s: None
    • Component/s: Authentication, Language
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable and set up LDAP authentication
      2. Run the scheduled task

        php admin/tool/task/cli/schedule_task.php --execute=\\auth_ldap\\task\\sync_task

        You should see "No user entries to be added" with a newline after it.

      Show
      Enable and set up LDAP authentication Run the scheduled task php admin/tool/task/cli/schedule_task.php --execute=\\auth_ldap\\task\\sync_task You should see "No user entries to be added" with a newline after it.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      wip-mdl-52672

      Description

      At some point between Moodle 2.6 and 3.0, the default value for the "nouserstobeadded" string in auth/ldap/lang/en/auth_ldap.php was changed from "No users to be added" to "No user entries to be added". This is fine, of course, but it seems that the \n newline character was accidentally omitted from that string in this file. As such, it's throwing off the structure of my log file that captures the results from this script's execution.

      By comparison, note that the other related strings in the file all have newline characters: "nouserentriestorevive", "nouserentriestoremove", etc.

      Correct line should read

      $string['nouserstobeadded'] = "No user entries to be added\n";
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: