Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52673

Workshop rubric list mode displays dndnotsupported message incorrectly on assessment form

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Preparation:

      • As a teacher:
        • Create a Workshop activity, ensuring that you choose the following options:
          • Grading strategy: Rubric
          • Maximum number of overall feedback attachments: 1 (or higher)
        • In the "Edit assessment form" step in the Setup phase, create a basic rubric using the "List" layout (in the "Rubric configuration" section at the end of the form)
        • Set the Workshop activity to Submission phase
      • As a student:
        • Make a submission
      • As a teacher:
        • Set the Workshop activity to Assessment phase

      Test:

      • As a teacher:
        • Assess the student's submission
        • Confirm that the "drag and drop not supported" message does NOT appear (in browsers which DO support DnD)
        • Confirm that the rubric displays in an acceptable manner

      You can also (as a teacher) assign the submission to another student, and use the second student to assess the first student's submission (instead of or as well as assessing as a teacher).

      Show
      Preparation: As a teacher: Create a Workshop activity, ensuring that you choose the following options: Grading strategy: Rubric Maximum number of overall feedback attachments: 1 (or higher) In the "Edit assessment form" step in the Setup phase, create a basic rubric using the "List" layout (in the "Rubric configuration" section at the end of the form) Set the Workshop activity to Submission phase As a student: Make a submission As a teacher: Set the Workshop activity to Assessment phase Test: As a teacher: Assess the student's submission Confirm that the "drag and drop not supported" message does NOT appear (in browsers which DO support DnD) Confirm that the rubric displays in an acceptable manner You can also (as a teacher) assign the submission to another student, and use the second student to assess the first student's submission (instead of or as well as assessing as a teacher).
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52673-master

      Description

      If attachments are enabled for assessments, the assessment mode is "rubric" and the rubric is set to "list" view, a CSS rule with an insufficiently specific selector kicks in and sets all spans in the form which are within .felement elements to display:block (rather than just those within the "rubric" part of the form). This results in the "drag and drop not supported" message being displayed on the file manager, even in browsers which do support drag and drop.

      There doesn't actually appear to be any need to set display:block on the span tags within the rubric anyway - perhaps this is a legacy from Moodle <2.0 (this CSS seems to predate 2.0) when mforms were displayed differently. Removing the troublesome rule tightens the space between levels slightly; there are already line breaks which force each level onto its own line.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Mar/16