Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52697

Undefined variable 'name' from calendar lib

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log into Moodle as an administrator.
      2. Click on the date on the calendar block.
      3. Click on manage subscriptions
      4. Add a calendar using the URL "https://www.google.com/calendar/ical/en.australian%23holiday%40group.v.calendar.google.com/public/basic.ics".
      5. When you click 'add' ensure you see a message telling you the number of events imported and updated before being redirected.
      6. Go to any page with the calendar block and make sure that there is no notice.
      7. Click on the calendar block and check that there are no notices in calendar/view.php
      Show
      Log into Moodle as an administrator. Click on the date on the calendar block. Click on manage subscriptions Add a calendar using the URL "https://www.google.com/calendar/ical/en.australian%23holiday%40group.v.calendar.google.com/public/basic.ics". When you click 'add' ensure you see a message telling you the number of events imported and updated before being redirected. Go to any page with the calendar block and make sure that there is no notice. Click on the calendar block and check that there are no notices in calendar/view.php
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-52697-master

      Description

      I'm now getting the following notice:

      Notice: Undefined variable: name in /home/adrian/moodles/stable_master_postgres/moodle/calendar/lib.php on line 396

      This is from issue MDL-52258 which removed the following line:
      $name = format_string($event->name, true);

      It should probably be investigated.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Simey Lameze
              Integrator:
              Dan Poltawski
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16