Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.9.3, 3.0.1
-
Fix Version/s: 3.1
-
Component/s: Plagiarism
-
Labels:
-
Testing Instructions:
- Run cron unit tests
- Install a plagiarism plugin and confirm that it still works as before (particularly the cron job)
-
Affected Branches:MOODLE_29_STABLE, MOODLE_30_STABLE
-
Fixed Branches:MOODLE_31_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
There are a couple of things that seem a bit inaccurate in the plagiarism_plugin base class:
- the class should be marked as abstract as it's intended only to be used as a base for extending
- the plagiarism_cron() method appears to be named wrongly, based on the calling code in plagiarismlib.php (where the plagiarism_cron() function is assuming a method called "cron" exists and calling it)
Neither of these should be a problem, as long as a plagiarism plugin implements a cron() method, but it would be better if the base class could be sorted out.
Attachments
Issue Links
- Testing discovered
-
MDL-52846 Deprecation of legacy cron
-
- Closed
-