Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52702

Deprecate old cron function in plagiarism API (was "Problems with plagiarism_plugin class")

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9.3, 3.0.1
    • 3.1
    • Plagiarism

    Description

      There are a couple of things that seem a bit inaccurate in the plagiarism_plugin base class:

      1. the class should be marked as abstract as it's intended only to be used as a base for extending
      2. the plagiarism_cron() method appears to be named wrongly, based on the calling code in plagiarismlib.php (where the plagiarism_cron() function is assuming a method called "cron" exists and calling it)

      Neither of these should be a problem, as long as a plagiarism plugin implements a cron() method, but it would be better if the base class could be sorted out.

      Attachments

        Issue Links

          Activity

            People

              maherne Michael Aherne
              maherne Michael Aherne
              Simey Lameze Simey Lameze
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                23/May/16