Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52715

Create a new requires class for implementing mforms in AJAX.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Pull in the following branch for testing: https://github.com/moodle/moodle/compare/master...abgreeve:MDL-52715-testing-branch.
      2. Create an assignment.
        • Make sure that you have file submissions.
        • Grading should be done with rubric.
      3. Create a rubric for marking.
      4. As a student add a submission that is a PDF (testing of annotated pdf).
      5. Go view the single grading page for the student as a teacher.
      6. Check that each of the elements work on the page. (Submission is not connected so will return an error. This is not part of this issue.)
      7. Add a different student number in the top box and click go.
      8. Check that the page changes with the students information.
      9. No javascript errors should be found.
      Show
      Pull in the following branch for testing: https://github.com/moodle/moodle/compare/master...abgreeve:MDL-52715-testing-branch . Create an assignment. Make sure that you have file submissions. Grading should be done with rubric. Create a rubric for marking. As a student add a submission that is a PDF (testing of annotated pdf). Go view the single grading page for the student as a teacher. Check that each of the elements work on the page. (Submission is not connected so will return an error. This is not part of this issue.) Add a different student number in the top box and click go. Check that the page changes with the students information. No javascript errors should be found.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-52715-master-additional

      Description

      With some experimenting we have found that creating a new requires class to divert JavaScript requires allows for mforms to be loaded via AJAX with the JavaScript still working.

      We need to create some additional methods to let third party plugins hook into this class and record it's required JavaScript for the AJAX form.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              David Monllaó
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16