Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52724

Atto does not generate UL tags when pasting LI tags

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.9.3, 3.1.4, 3.6, 3.10.1
    • Fix Version/s: None
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide

      Manual Testing

      Note: Firefox is the most problematic of the common browsers, so is probably the most important to test. But different browsers will behave differently in these tests - but they should all produce non-broken results, even if they aren't identical.

      1. In a course, edit a course topic, adding a list (bulleted or numbered), of at least 4 items.
      2. Save
      3. In the displayed list, copy some number of list items.
      4. Edit a different course topic.
      5. In the new topic, paste the list items.
      6. Save.
      7. Confirm that the course layout still looks as expected.
      8. Repeat the above steps with different combinations of copy/pasted list items/designes.
      9. Edit a course topic.
      10. Switch to HTML view in Atto.
      11. Try out some different combinations of incorrectly formated lists (li tags not in a ul/ol, extra or missing opening/closing tags, etc).
      12. Save.
      13. Confirm that the course layout still looks as expected.

      Behat Testing

      This patch does have behat tests that are expected to pass.

      Atto plugin tester

      Note: This will be easiest/most comprehensive if you can access the site(s) from multiple browser/OS combos.

      1. Download and install the plugin atto_cleantest from https://github.com/merrill-oakland/moodle-atto_cleantest
      2. Assign the plugin button to the Atto tool bar by adding cleantest to the editor_atto/toolbar setting. I add it near the start.
      3. In each browser that you wish to test, go to any Atto editor, and click the "?" (Cleaner Test) button.
      4. Confirm that all tests pass (should report around 37 tests)
      Show
      Manual Testing Note: Firefox is the most problematic of the common browsers, so is probably the most important to test. But different browsers will behave differently in these tests - but they should all produce non-broken results, even if they aren't identical. In a course, edit a course topic, adding a list (bulleted or numbered), of at least 4 items. Save In the displayed list, copy some number of list items. Edit a different course topic. In the new topic, paste the list items. Save. Confirm that the course layout still looks as expected. Repeat the above steps with different combinations of copy/pasted list items/designes. Edit a course topic. Switch to HTML view in Atto. Try out some different combinations of incorrectly formated lists (li tags not in a ul/ol, extra or missing opening/closing tags, etc). Save. Confirm that the course layout still looks as expected. Behat Testing This patch does have behat tests that are expected to pass. Atto plugin tester Note: This will be easiest/most comprehensive if you can access the site(s) from multiple browser/OS combos. Download and install the plugin atto_cleantest from https://github.com/merrill-oakland/moodle-atto_cleantest Assign the plugin button to the Atto tool bar by adding cleantest to the editor_atto/toolbar setting. I add it near the start. In each browser that you wish to test, go to any Atto editor, and click the "?" (Cleaner Test) button. Confirm that all tests pass (should report around 37 tests)
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_310_STABLE, MOODLE_31_STABLE, MOODLE_36_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-52724-310
    • Pull 3.11 Branch:
      MDL-52724-311
    • Pull Master Branch:
      MDL-52724-master

      Description

      Hello,

      Is it possible that version 2.9.3+ no longer generates the <ul> & </ul> tags within labels in Moodle?

      The trouble arises when someone either pastes or manually enters the tag “<li>” within a label in Moodle. When using the bullet point button in the ATTO editor, the necessary “<ul>” tag is added to make an ordered list; however, sometimes the “<ul>” tag is either unwittingly deleted by the user within the html view, or is never present because of text copied and pasted from an alternative source. This means that all content following the defective tag will be changed to that of an ordered list, including blocks and such, which causes significant and startling changes to any course site.

      Ex of problem code:
      <div style="width: 90%; padding: 5px 0px; border-top: 4px solid #c00; border-bottom: 2px solid #c00;">
      <p style="font-size: 1.5em; border-bottom: 1px solid #a0a0a0; padding: 0 0 5px 0; margin: 0 0 5px 0;">[Course Section(s), Building(s) and Room(s), Time]</p>
      <p style="font-size: 1.2em; margin: 0 0 0 0;"><strong>Instructor:</strong> [Your Name] [email@iastate.edu] <br> <strong>Office:</strong> [Your office building and room] <br><strong>Office Hours:</strong> [Your office hours]</p>
      </div>
      <li></li>

      Ex of working code
      <div style="width: 90%; padding: 5px 0px; border-top: 4px solid #c00; border-bottom: 2px solid #c00;">
      <p style="font-size: 1.5em; border-bottom: 1px solid #a0a0a0; padding: 0 0 5px 0; margin: 0 0 5px 0;">[Course Section(s), Building(s) and Room(s), Time]</p>
      <p style="font-size: 1.2em; margin: 0 0 0 0;"><strong>Instructor:</strong> [Your Name] [email@iastate.edu] <br> <strong>Office:</strong> [Your office building and room] <br><strong>Office Hours:</strong> [Your office hours]</p>
      </div>
      <ul><li></li></ul>

      We have a backup version of Moodle using running on version 2.8.6, which does not have this issue. In other words, it automatically generates the <ul> & </ul> tags regardless of how I meddle with it. This issue occurs regardless of theme and with or without our custom CSS style sheet.

      Is there any way I can restore the previous functionality so as to make the system more user friendly for our instructors? Thank you kindly.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              emerrill Eric Merrill
              Reporter:
              balutz Bryan A Lutz
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              32 Vote for this issue
              Watchers:
              34 Start watching this issue

                Dates

                Created:
                Updated: