Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52754

Dropdown list of scales is not displayed when there's single quotes in values

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: None
    • Component/s: Competencies
    • Labels:
    • Testing Instructions:
      Hide

      Check cachejs parameter is checked.
      Create 2 scales. One should have a value with a single quote.
      Create a framework and with the first scale.
      Add a competency to the framework with the framework scale.
      Add an other competency with the second scale.

      Clear the cache: Development Purge all caches.
      Create a user learning plan and add both competencies to it.
      Click on first competency. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly.
      Go back to the list of Learning plan competencies.
      Click on second competency. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly.
      Redo preceding steps for one competency. Scale value comes from the cache and you must get the same result.

      Clear the cache: Development Purge all caches.
      Create a course.
      Enroll a user.
      Link both competencies to the course
      Click on first competency. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly.
      Go back to the list of Learning plan competencies.
      Click on second competency. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly.

      Clear the cache: Development Purge all caches.
      Go to Competency breakdown: Course administration Reports Competency breakdown.
      For first competency click in Rating column. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly.
      Go back to the competency breakdown list.
      For second competency click in Rating column. Click on Rate button.
      You access the Rate dialogue.
      Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly.

      Show
      Check cachejs parameter is checked. Create 2 scales. One should have a value with a single quote. Create a framework and with the first scale. Add a competency to the framework with the framework scale. Add an other competency with the second scale. Clear the cache: Development Purge all caches. Create a user learning plan and add both competencies to it. Click on first competency. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly. Go back to the list of Learning plan competencies. Click on second competency. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly. Redo preceding steps for one competency. Scale value comes from the cache and you must get the same result. Clear the cache: Development Purge all caches. Create a course. Enroll a user. Link both competencies to the course Click on first competency. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly. Go back to the list of Learning plan competencies. Click on second competency. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly. Clear the cache: Development Purge all caches. Go to Competency breakdown: Course administration Reports Competency breakdown. For first competency click in Rating column. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values (from scale associated to the framework) are displayed correctly. Go back to the competency breakdown list. For second competency click in Rating column. Click on Rate button. You access the Rate dialogue. Check in dropdown list that all scale values(from scale associated to the second competency) are displayed correctly.
    • Affected Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-52754_master
    • Story Points:
      2
    • Sprint:
      CBE Sprint 4, CBE Sprint 5, CBE Sprint 6

      Description

      When preparing a demo of the tool_lp plugin, I noticed that the dropdown list of scales is not displayed in the user competency screen when there's one or more single quotes (') in the scale values (See attachments).

      It seems that this character (and possibly other special characters) is not escaped properly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sergeg55 Serge Gauthier
                Reporter:
                gaudreaj Jean-Philippe Gaudreau
                Peer reviewer:
                Frédéric Massart
                Participants:
                Component watchers:
                Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: