Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52825

atto:selectionchanged is fired for each click on the page

    XMLWordPrintable

Details

    • MOODLE_29_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MDL-52825_master
    • Hide

      Test 1

      1. Repeat MDL-45338 testing instructions
      2. It should all work as expected

      Test 2

      1. With DEBUG_DEVELOPER debug level
      2. Open your inspector and locate editor-debug.js file
      3. Add a breakpoint to the return; line added by this issue
      4. Go to a form with an editor on it
      5. Click around the page, the return should be executed for each click
      6. Now click on the editor toolbar or the editor editing area
      7. The return should not be executed
      Show
      Test 1 Repeat MDL-45338 testing instructions It should all work as expected Test 2 With DEBUG_DEVELOPER debug level Open your inspector and locate editor-debug.js file Add a breakpoint to the return; line added by this issue Go to a form with an editor on it Click around the page, the return should be executed for each click Now click on the editor toolbar or the editor editing area The return should not be executed
    • 3.1 Sprint 3

    Description

      We only need to notify if the selection has changed when there are changes in the editor scope, we are not currently limiting it so any click anywhere makes _hasSelectionChanged run and in most of the cases it is considering that it changes because the range is different from the editor selected range.

      Found while working on MDL-52715 as Y.soon was still working after removing the involved DOM nodes.

      Attachments

        Issue Links

          Activity

            People

              dmonllao David Monllaó
              dmonllao David Monllaó
              cameron1729 cameron1729
              Dan Poltawski Dan Poltawski
              Rajesh Taneja Rajesh Taneja
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.