Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52838

Undefined variable 'type' on workshop assessment form

    Details

    • Testing Instructions:
      Hide

      Enable debugging.
      Test in clean theme.
      Create a workshop with the grading strategy set to rubric.
      Edit the assessment form and provide a description for the first 3 criterion, but do not define any levels.
      Click "Save and Preview" and confirm there are 3 validation errors.
      Enter some text for the second level of the first criterion and click "Save and Preview" again.
      Confirm you now only have 2 validation errors.
      Remove the description of the second criterion and click "Save and Preview" again.
      Confirm you now only have 1 validation errors.
      Provide descriptions for 4 levels in the 3rd criterion and click "Save and Preview" again.
      Confirm you see the assessment form preview and there are no debugging errors.

      Show
      Enable debugging. Test in clean theme. Create a workshop with the grading strategy set to rubric. Edit the assessment form and provide a description for the first 3 criterion, but do not define any levels. Click "Save and Preview" and confirm there are 3 validation errors. Enter some text for the second level of the first criterion and click "Save and Preview" again. Confirm you now only have 2 validation errors. Remove the description of the second criterion and click "Save and Preview" again. Confirm you now only have 1 validation errors. Provide descriptions for 4 levels in the 3rd criterion and click "Save and Preview" again. Confirm you see the assessment form preview and there are no debugging errors.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull 3.3 Branch:
    • Pull Master Branch:
      MDL-52838-master

      Description

      As a teacher:

      • Use Clean theme (with Boost the error doesn't appear).
      • Create a Workshop activity, ensuring that you choose the following options:
      • Grading strategy: Rubric
      • Maximum number of overall feedback attachments: 1 (or higher)
      • In the "Edit assessment form" step in the Setup phase, create a basic rubric using the "List" layout (in the "Rubric configuration" section at the end of the form)
      • Press "Save and display" - you should see a notice:

         Notice: Undefined variable: type in /path/to/mymoodle/moodle/lib/pear/HTML/QuickForm/group.php on line 286

      This also causes problems later when the same form (I believe) is used to assess a student's submission. It appears that part of the form is not rendered, as when you try to save the assessment an error stating You have to select one of these items is displayed, yet there are no items to select.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Nov/17