Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52999

External functions in mod_assign does not check if subplugins are disabled (or not visible)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins and disable the file or comments plugin
      2. Do the same for Submission plugins, disable file or online text
      3. Now go to Site administration / ▶︎ Plugins / ▶︎ Web services / ▶︎ API Documentation
      4. Check that in the save_grade function, in the function parameters plugindata section, there is not references for the feedback disabled plugin
      5. Do the same for save_submission function but for the submission disabled plugin
      6. Enable both plugins again, go to the documentation page and check that now you see the plugins referenced
      7. Check that in both cases, the external structure is now marked as optional in the parameters definition
      Show
      Go to Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins and disable the file or comments plugin Do the same for Submission plugins, disable file or online text Now go to Site administration / ▶︎ Plugins / ▶︎ Web services / ▶︎ API Documentation Check that in the save_grade function, in the function parameters plugindata section, there is not references for the feedback disabled plugin Do the same for save_submission function but for the submission disabled plugin Enable both plugins again, go to the documentation page and check that now you see the plugins referenced Check that in both cases, the external structure is now marked as optional in the parameters definition
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52999-master

      Description

      When I was reviewed the existent assignment external functions I noticed that when the assignment subplugins (feedback or submission) are used, there are not checks for it current visibility or availability.

      These checks are correctly done in the locallib.php file (assign class) but not in the external functions.

        Attachments

          Activity

            People

            Assignee:
            jleyva Juan Leyva
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Simey Lameze
            Integrator:
            Dan Poltawski
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/May/16