Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53008

JS memory leak in filter_glossary

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.9.4
    • Fix Version/s: None
    • Component/s: Filters, Glossary
    • Labels:
    • Affected Branches:
      MOODLE_29_STABLE

      Description

      As pointed out by Andrew in https://tracker.moodle.org/browse/MDL-51075?focusedCommentId=393487&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-393487, filter glossary is the proud host of one of our JS memory leaks.

      To reproduce:

      1. Add a mod_page instance with a big text containing a glossary entry concept (autolinked) multiple times
      2. Go to the mod_page page
      3. Open timeline chrome dev tools tab and start recording
      4. Open and close the glossary concept JS popup a few times, you can try forcing garbage collection after closing a popup so we are sure that all memory that will be freed is freed
      5. Stop recording and see how JS, nodes and listeners has been going up for each alertpanel that was opened.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  dmonllao David Monllaó
                  Participants:
                  Component watchers:
                  Jake Dallimore, Jun Pataleta, Adrian Greeve, Mihail Geshoski
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated: