Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53029

Book hidden chapter block contains markup in alt and title attributes.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 2.9.5, 3.0.2
    • 2.9.4, 3.0.2
    • Accessibility, Book
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • wip_MDL-53029_master
    • Hide
      1. In a course, create a book with three sample chapters.
      2. On the table of contents block, hide chapter two with the eye.
      3. Inspect the markup of the chapter's action list:
        • Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').
      4. Make the 3rd chapter as a subchapter.
      5. Hide the subchapter.
      6. Inspect the markup of the subchapter's action list:
        • Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').
      Show
      In a course, create a book with three sample chapters. On the table of contents block, hide chapter two with the eye. Inspect the markup of the chapter's action list: Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"'). Make the 3rd chapter as a subchapter. Hide the subchapter. Inspect the markup of the subchapter's action list: Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').

      Ref: https://moodle.org/mod/forum/discuss.php?d=327661#p1317724

      When hiding a chapter in a book, the book table of contents block changes to reflect this. However the alt and title attributes of the link and image tags contain embedded span tags which have speech marks. In other themes (besides Clean) this is breaking things. In Clean it does not make any difference visually, however from an accessibility point of view I dread to think what the screen reader says to the user.

        1. 2016-02-08 13_31_45-A book_ Two.png
          2016-02-08 13_31_45-A book_ Two.png
          90 kB
        2. 2016-02-09 18_19_42-WinMerge - [locallib_patch.php - locallib.php].png
          2016-02-09 18_19_42-WinMerge - [locallib_patch.php - locallib.php].png
          85 kB

            gb2048 Gareth J Barnard
            gb2048 Gareth J Barnard
            Jun Pataleta Jun Pataleta
            Dan Poltawski Dan Poltawski
            Ryan Wyllie Ryan Wyllie
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.