Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53029

Book hidden chapter block contains markup in alt and title attributes.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.4, 3.0.2
    • Fix Version/s: 2.9.5, 3.0.2
    • Component/s: Accessibility, Book
    • Labels:
    • Testing Instructions:
      Hide
      1. In a course, create a book with three sample chapters.
      2. On the table of contents block, hide chapter two with the eye.
      3. Inspect the markup of the chapter's action list:
        • Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').
      4. Make the 3rd chapter as a subchapter.
      5. Hide the subchapter.
      6. Inspect the markup of the subchapter's action list:
        • Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').
      Show
      In a course, create a book with three sample chapters. On the table of contents block, hide chapter two with the eye. Inspect the markup of the chapter's action list: Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"'). Make the 3rd chapter as a subchapter. Hide the subchapter. Inspect the markup of the subchapter's action list: Confirm no 'span' tags in the 'alt' and 'title' tags of the chapter action list (the 'div class="action-list"').
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-53029_master
    • Pull Master Diff URL:

      Description

      Ref: https://moodle.org/mod/forum/discuss.php?d=327661#p1317724

      When hiding a chapter in a book, the book table of contents block changes to reflect this. However the alt and title attributes of the link and image tags contain embedded span tags which have speech marks. In other themes (besides Clean) this is breaking things. In Clean it does not make any difference visually, however from an accessibility point of view I dread to think what the screen reader says to the user.

        Attachments

          Activity

            People

            Assignee:
            gb2048 Gareth J Barnard
            Reporter:
            gb2048 Gareth J Barnard
            Peer reviewer:
            Jun Pataleta
            Integrator:
            Dan Poltawski
            Tester:
            Ryan Wyllie
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, David Jones, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jan/16