Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53033

Invalid attribute values for div.c1.btn

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.5, 3.0.3, 3.1
    • Fix Version/s: 2.9.6, 3.0.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Add the 'Login' block to the front page.
      2. Log out.
      3. Inspect the div containing 'Log in' button in the browser development tools.
      4. Confirm that background-repeat and border-radius are set to "no-repeat" and "0" respectively and that the browser isn't reporting them as an invalid style (see attached picture for example of invalid style).
      Show
      Add the 'Login' block to the front page. Log out. Inspect the div containing 'Log in' button in the browser development tools. Confirm that background-repeat and border-radius are set to "no-repeat" and "0" respectively and that the browser isn't reporting them as an invalid style (see attached picture for example of invalid style).
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-53033_master

      Description

      The 'Log in' button on the login block has a button that is styled with the div.c1.btn selector. Chrome reports that the background-repeat and background-radius have invalid values. Both are set to 'none' when they should be 'no-repeat' and '0' respectively. Clearly the intent of the selector attributes has been lost.

      LESS / CSS is located here: https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/undo.less#L131

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gb2048 Gareth J Barnard
              Reporter:
              gb2048 Gareth J Barnard
              Peer reviewer:
              Marina Glancy
              Integrator:
              Dan Poltawski
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16