Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53049

Improve positioning of page when #anchors in use on bootstrapbase themes to take account of header

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.4, 3.0.2, 3.1
    • Fix Version/s: 3.1
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-53049-anchor-offset
    • Testing Instructions:
      Hide

      Specific places in moodle to test both as < 980 (which should be flush with the top) and > 980 pixel screen widths which should add the extra padding to sit under the static header:

      1. forum deep link to post eg /mod/forum/discuss.php?d=2&postid=80#p80
      2. wiki table of contents eg /mod/wiki/view.php?pageid=3&group=0#toc-1
      Show
      Specific places in moodle to test both as < 980 (which should be flush with the top) and > 980 pixel screen widths which should add the extra padding to sit under the static header: forum deep link to post eg /mod/forum/discuss.php?d=2&postid=80#p80 wiki table of contents eg /mod/wiki/view.php?pageid=3&group=0#toc-1

      Description

      With the default theme, and probably most themes based on it, when you deep link into a forum post with a #anchor link, the anchor aligns perfectly flush with the top of the browser window.

      However the bootstrap top bar covers this so the post you are trying to look at is partially obscured.

      See the screen shot below (note in that screenshot there is some styling related to this issue which highlights the target post, see also MDL-53050)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              brendanheywood Brendan Heywood
              Reporter:
              brendanheywood Brendan Heywood
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16