Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53061

Grunt watch and various directory handling improvements (backport of MDL-49817)

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.9.5, 3.0.3
    • 2.9.4, 3.0.2
    • Libraries
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • Easy
    • Hide
      1. Run npm install to get updated grunt requirements
      2. Run grunt watch and change many different files (amd js, yui js, bootstrapbase .less} files and ensure they are rebuilt correctly
      3. Run other grunt commands and ensure they work as expected
      Show
      Run npm install to get updated grunt requirements Run grunt watch and change many different files (amd js, yui js, bootstrapbase .less} files and ensure they are rebuilt correctly Run other grunt commands and ensure they work as expected

      In MDL-49817 I added support for 'grunt watch' which allows files to be built on save.

      I also simplified a lot of the grunt code and improved the 'in directory handling' which fixed MDL-53059 and improved some other cases too.

      I want to propose this is backported.

      Reasons for backporting:

      • It's a developer tool - no impact to users, it either works or doesn't (a bit like our testing infra improvements)
      • To fix the other 'directory handing' bugs i'd be inclined to do the same cleanup i've done in MDL-49817 (main motivation for creating this request)
      • It's useful watch functionality and keeps commands consistent between versions
      • Any regressions would impact the developer when building master anyway

      Reasons against backporting:

      • It'll require an `npm install` by developers
      • You probably would only use `grunt watch` on one branch (master likely) then build on backport
      • The gruntfile has been significantly refactored

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.