Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53077

Add page action to body CSS ID in mod_assign

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. View an assignment.
        • confirm that the body element id is "page-mod-assign-view".
      2. View the assignment.grading page (with the table of submissions)
        • confirm that the body element id is "page-mod-assign-grading".
      3. View the grade submission page.
        • confirm that the body element id is "page-mod-assign-grade".
      4. Optionally, view other mod_assign pages with different querystring action values
        • The body element id should be "page-mod-assign-$action".
      Show
      View an assignment. confirm that the body element id is "page-mod-assign-view". View the assignment.grading page (with the table of submissions) confirm that the body element id is "page-mod-assign-grading". View the grade submission page. confirm that the body element id is "page-mod-assign-grade". Optionally, view other mod_assign pages with different querystring action values The body element id should be "page-mod-assign- $action ".
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The mod assign's .path-* id in the body tag does not distinguish between view, grading, and grade actions.

      As these are pages with significantly different content, it would be helpful to distinguish between them (e.g. to provide more space for mod assign's grading table (action=grading) in a theme that limits the page width).

      I originally proposed adding an action-* class to the body in MDL-52875, but Marina Glancy suggested that this would be a better approach.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              balchd Dave Balch
              Reporter:
              balchd Dave Balch
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Dan Poltawski
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16