-
Bug
-
Resolution: Fixed
-
Major
-
3.0.2, 3.0.5, 3.1.1
-
MOODLE_30_STABLE, MOODLE_31_STABLE
-
MOODLE_30_STABLE, MOODLE_31_STABLE
-
MDL-53152-master -
Difficult
-
-
1
-
3.1 Sprint 7, 3.2 Sprint 3
-
Medium
I use a moodle theme which is based on bootstrapbase. After upgraded the moodle from 2.9 to 3.0-latest, the dropdown menu cannot be shown correctly. Compared with 2.9, I found the 3.0 missed one css style which is defined in theme/bootstrapbase/style/moodle.css:
@media (min-width:980px){.nav-collapse.collapse{height:auto !important;overflow:visible !important}}
In 3.0 it changed to :
@media (min-width:979px + 1){.nav-collapse.collapse{height:auto !important;overflow:visible !important}}
It is generated from theme/bootstrapbase/less/bootstrap/responsive-navbar.less, in which the variable @navbarCollapseDesktopWidth is refered. And the @navbarCollapseDesktopWidth is defined in theme/bootstrapbase/less/bootstrap/variables.less, like:
@navbarCollapseWidth: 979px;
@navbarCollapseDesktopWidth: @navbarCollapseWidth + 1;
The solution is adding parentheses for @navbarCollapseDesktopWidth in theme/bootstrapbase/less/bootstrap/responsive-navbar.less, like:
@media (min-width: (@navbarCollapseDesktopWidth)) {
then generating the moodle.css file again by using: grunt css.
- is a regression caused by
-
MDL-51582 Switch to grunt to compile LESS as recess is no longer maintained
-
- Closed
-