Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53172

Expand inplace_editable to cater for toggle and selects

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      This issue only adds functionality but there are no usages of it yet.

      To check for regressions make sure that course section names are editable in-place and so are tag names on "Manage tags" page.

      1. Pick the last commit from branch
      2. Go to Site administration>Appearance>Manage tags
      3. Make sure you can enable/disable each tag area (this is "toggle" inplace editable)
      4. Make sure after each change the table row becomes dimmed/not dimmed (this is testing js events observing)
      5. Make sure you can change the "standard tags use" for each tag area (this is "select" inplace editable)
      6. Create new tag collection
      7. Make sure that you can now select tag collection for each tag area (again, "select")

      Test in both clean and base themes

      Show
      This issue only adds functionality but there are no usages of it yet. To check for regressions make sure that course section names are editable in-place and so are tag names on "Manage tags" page. Pick the last commit from branch Go to Site administration>Appearance>Manage tags Make sure you can enable/disable each tag area (this is "toggle" inplace editable) Make sure after each change the table row becomes dimmed/not dimmed (this is testing js events observing) Make sure you can change the "standard tags use" for each tag area (this is "select" inplace editable) Create new tag collection Make sure that you can now select tag collection for each tag area (again, "select") Test in both clean and base themes
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-MDL-53172-master

      Description

      Add input type to the inplace_editable element (default text as it is now)
      other options (to start with):

      • toggle
      • dropdown

      Other changes to the existing element in this issue:

      • add loading spinner during update
      • fixed bug with 'updated' trigger not working after the first time
      • if the text/select element does not have a link in display value, make the whole element clickable

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16