Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53175

Multimedia filter is not applied in WS pluginfile if the file name has spaces, underscores, etc.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a page and book activity
      2. In the page and in a book chapter embed a video file (using the text editor button for embedding media) with blank spaces in his name "my video.mp4" for example, you can use the attached video
      3. Export the book to IMSCP and check that once downloaded the package you can see the video player (you need to download the zip and uncompress it)
      4. Using the Mobile app open the page and the book and check that you can see the video player (please, note that there is a bug in the app pending to be solved so maybe you can't play the video in the app), but the important thing is that you see the video player
      Show
      Create a page and book activity In the page and in a book chapter embed a video file (using the text editor button for embedding media) with blank spaces in his name "my video.mp4" for example, you can use the attached video Export the book to IMSCP and check that once downloaded the package you can see the video player (you need to download the zip and uncompress it) Using the Mobile app open the page and the book and check that you can see the video player (please, note that there is a bug in the app pending to be solved so maybe you can't play the video in the app), but the important thing is that you see the video player
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53175-master
    • Pull Master Diff URL:

      Description

      In the Mobile app we use the script webservice/pluginfile.php to download the pages of mod_book, mod_page and mini-site mod_resource. Example of a request:

      http://mysite.com/webservice/pluginfile.php/78/mod_book/chapter/26/index.html?token=mytoken

      Today I noticed that the videos and audios added to the book/page that have spaces or underscores in the name aren't treated by the multimedia plugin, we receive them as plain links (<a>). If the file names are just alphanumeric then I receive the HTML5 player as it should. I only tried with spaces and underscores, I guess it'll happen with other characters too.

      After some more testing I noticed that this also happens when exporting a Book that contains media element with spaces to an IMS CP package, if the media file has spaces in his name filters are not applied, I'm attaching screenshots right now

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-4464 @@PLUGINFILE@@ appears in the HTML body of a forum email notification.

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Mark Nelson
              Integrator:
              Dan Poltawski
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16