Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53176

Grade history report hangs -- previous grade subquery (backport of MDL-50385)

    XMLWordPrintable

Details

    • MOODLE_29_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • Easy
    • Hide
      1. Start with a non-upgraded site
      2. Make sure you have performance debugging info on
      3. Create a Medium tests course
      4. Use the single grade report to grade an activity, bulk inserting 100 for all grades (this will probably take a long time)
      5. Use the single grade report to grade an activity, bulk inserting 75 for all grades (this will probably take a long time)
      6. Use the single grade report to grade an activity, bulk inserting 50 for all grades (this will probably take a long time)
      7. Go to the grade history report. After it loads, note the DB Queries Time. I see in the order of 4.5s
      8. Run the upgrade in this ticket
      9. Go back to the grade history report and check the DB Queries Time, it should be significantly decreased. (You can compare with your stable to see the difference)
      Show
      Start with a non -upgraded site Make sure you have performance debugging info on Create a Medium tests course Use the single grade report to grade an activity, bulk inserting 100 for all grades (this will probably take a long time) Use the single grade report to grade an activity, bulk inserting 75 for all grades (this will probably take a long time) Use the single grade report to grade an activity, bulk inserting 50 for all grades (this will probably take a long time) Go to the grade history report. After it loads, note the DB Queries Time. I see in the order of 4.5s Run the upgrade in this ticket Go back to the grade history report and check the DB Queries Time, it should be significantly decreased. (You can compare with your stable to see the difference)

    Description

      The fix in MDL-50385 should be safe to backport to support Moodle versions and resolves a critical issue with the Gradebook History report that makes it unusable in sites with a large amount of gradebook history, and puts significant unnecessary strain on the database.

      Attachments

        Issue Links

          Activity

            People

              emerrill Eric Merrill
              kstokking Kris Stokking
              Simey Lameze Simey Lameze
              David Monllaó David Monllaó
              Frédéric Massart Frédéric Massart
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
              Votes:
              1 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/May/16