Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53179

Download all folder files under .folder-edit-button node

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a folder activity.
      2. Add two files to it.
      3. View the activity.
      4. There will be two buttons - edit and download in two seperate divs - folder-download-button and folder-edit-button.
      5. Check they both work as expected.
      Show
      Create a folder activity. Add two files to it. View the activity. There will be two buttons - edit and download in two seperate divs - folder-download-button and folder-edit-button. Check they both work as expected.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:

      Description

      In MDL-51306 we added the option to bulk download all files within a folder, we added the new button under a container with .folder-edit-button CSS class, the name of the class references edit button but now it contains more stuff than that. We are not going to die if we don't fix this, but in case anyone is interested I can think of some alternatives:

      1. Rename folder-edit-button (with a note in theme/upgrade.txt)
      2. Add a new container for download folder with a new css selector, probably same styling than .folder-edit-button
      3. Do nothing and close this

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16