Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53206

get_many does not dereference objects

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2
    • Fix Version/s: 2.9.5, 3.0.3
    • Component/s: Caching
    • Labels:

      Description

      When reviewing the caching code, I noticed that get_many and set_many don't do what get and set do to manage references. In most cachestores this is find as in reality dereferencing is done when storing. But it's not true for php memory based function.

      There were no unit tests that covered the object scenario with get_many. That was added and showed this error to be true. The code has been altered return dereferenced objects.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mr-russ Russell Smith
              Reporter:
              mr-russ Russell Smith
              Peer reviewer:
              Eric Merrill
              Integrator:
              Andrew Nicols
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16