Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53210

Errors when displaying feedback that is not accessible

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2
    • Fix Version/s: 2.9.5, 3.0.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      Test 1.

      1. Give authenticated user on frontpage capability to view feedback
      2. Create a feedback on front page and map it to the courses. Hide it
      3. Go to the course where you mapped feedback to and add a feedback block
      4. Login as student - you should not see the feedback on the frontpage because it's hidden
      5. Go to the course - you should not see this feedback in the feedback block
      6. As admin unhide feedback
      7. As student go to the course - you should see this feedback in the feedback block
      8. As student go to frontpage and click on feedback name - you should see a notification that you must access feedback from the course

      Test 2.

      1. Give authenticated user on frontpage capability to view feedback but not capability to complete it
      2. Enable $CFG->feedback_allowfullanonymous
      3. Create feedback on the frontpage and add a question to it
      4. Login as guest and make sure you can complete this feedback
      5. Login as user, open the feedback and make sure you don't see a link to complete it
      6. As admin give authenticated user on frontpage capability to complete feedback
      7. Login as user and make sure you can view and complete this feedback
      8. As admin disable $CFG->feedback_allowfullanonymous
      9. Logout and try to attempt feedback as a guest - you should not be able to
      Show
      Test 1. Give authenticated user on frontpage capability to view feedback Create a feedback on front page and map it to the courses. Hide it Go to the course where you mapped feedback to and add a feedback block Login as student - you should not see the feedback on the frontpage because it's hidden Go to the course - you should not see this feedback in the feedback block As admin unhide feedback As student go to the course - you should see this feedback in the feedback block As student go to frontpage and click on feedback name - you should see a notification that you must access feedback from the course Test 2. Give authenticated user on frontpage capability to view feedback but not capability to complete it Enable $CFG->feedback_allowfullanonymous Create feedback on the frontpage and add a question to it Login as guest and make sure you can complete this feedback Login as user, open the feedback and make sure you don't see a link to complete it As admin give authenticated user on frontpage capability to complete feedback Login as user and make sure you can view and complete this feedback As admin disable $CFG->feedback_allowfullanonymous Logout and try to attempt feedback as a guest - you should not be able to
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-53210-master

      Description

      there is some default capabilities mix up (I reported MDL-53209 about it) but regardless of this here is a bug:

      Errors 1 & 2 :

      1. Give authenticated user on frontpage capability to view feedback (see MDL-53209 that this cap is missing by default)
      2. Create a feedback on front page and map it to the courses. Hide it
      3. Go to the course where you mapped feedback to and add a feedback block
      4. Login as student - you should not see the feedback on the frontpage because it's hidden
      5. Error1: Go to the course - you will see this feedback in the feedback block, clicking on it opens empty page
      6. As admin unhide feedback
      7. Error2: As student go to frontpage and click on feedback name - you will see a weird error about coursemodule id

      Error 3:

      1. Give authenticated user on frontpage capability to view feedback but not capability to complete it
      2. Enable $CFG->feedback_allowfullanonymous
      3. Create feedback on the frontpage and add a question to it
      4. Login as guest and make sure you can complete this feedback
      5. Login as student - you will be able to open feedback, you will see a link to attempt it but clicking on it will display an error

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Mar/16