Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53252

No need to call grade_regrade_final_grades from update_raw_grade and update_final_grade in some cases

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable $CFG->grade_report_showquickfeedback
      2. Create a course with a couple of activities and at least 1 student
      3. Grade the student activities
      4. Check that the total course grade is updated according to your gradebook setup (aggregation methods, min and max...)
      5. Update the student activities grades
      6. Check that the total course grade is updated according to your gradebook setup (aggregation methods, min and max...) and the new grades you set
      7. Add a debugging('yeah'); in grade_regrade_final_grades, on top, below \core_php_time_limit::raise call, we want to know if this function is being called, it should only be displayed when the grade_grades record do not exist and we add feedback before there is a grade
      8. Keep the gradebook tab like it is and update the student activities feedback (only the text) from the activity in another tab
      9. You SHOULD not see any debugging message
      10. Check that the feedback is updated in the gradebook tab, and the grade remains the same
      11. Keep the gradebook tab like it is and update the student activities feedback (only the text) from the gradebook (AJAX) in another tab
      12. You SHOULD NOT see any debugging message
      13. Check that the feedback is updated in the gradebook tab, and the grade remains the same
      Show
      Enable $CFG->grade_report_showquickfeedback Create a course with a couple of activities and at least 1 student Grade the student activities Check that the total course grade is updated according to your gradebook setup (aggregation methods, min and max...) Update the student activities grades Check that the total course grade is updated according to your gradebook setup (aggregation methods, min and max...) and the new grades you set Add a debugging('yeah'); in grade_regrade_final_grades, on top, below \core_php_time_limit::raise call, we want to know if this function is being called, it should only be displayed when the grade_grades record do not exist and we add feedback before there is a grade Keep the gradebook tab like it is and update the student activities feedback (only the text) from the activity in another tab You SHOULD not see any debugging message Check that the feedback is updated in the gradebook tab, and the grade remains the same Keep the gradebook tab like it is and update the student activities feedback (only the text) from the gradebook (AJAX) in another tab You SHOULD NOT see any debugging message Check that the feedback is updated in the gradebook tab, and the grade remains the same
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53252_master
    • Sprint:
      3.1 Sprint 5
    • Issue size:
      Small

      Description

      grade_item::update_raw_grade updates a user grade, it is called from grade_update, the one used by activities to send grades to the gradebook. It is good that we recalculate the whole set of grade_grades of that user in the course if the grade or the scale changes, but in some cases there is no need to call grade_regrade_final_grades, like a feedback change or just the timemodified.

      Based on https://tracker.moodle.org/browse/MDL-51149?focusedCommentId=396778&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-396778

        Attachments

          Activity

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16