Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53300

Incorrect check for modgrade_type

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Gradebook
    • Testing Instructions:
      Hide
      1. Update grade for non-graded activity
      1. Create an assignment with:
        • Grade Type = Point
        • Maximum Grade = 100
      2. Press Save and Display.
      3. Follow Edit settings and make sure
        • Grade Type = Point
        • Maximum Grade = 100
      4. Set Maximum Grade = 50 and Press save and Display
      5. Follow Edit Settings again
      6. Make sure:
        • Grade Type = Point
        • Maximum Grade = 50
      7. Set
        • Grade Type = Scale
        • Scale = Separate and Connected ways of knowing.
      8. Follow Edit Settings and make sure
        • Grade Type = Scale
        • Scale = Separate and Connected ways of knowing.
      2. Update grade for graded activity (Repeat MDL-48634) with js enabled
      1. Create an assignment
        • Grade Type = Point
        • Maximum Grade = 100
      2. Save grade for 1 or more students
      3. Follow Edit Settings and make sure
        • You see notification "Some grades have already been awarded" under grade section
        • Grade Type is disabled
        • Maximum Grade is disabled.
      4. Set "Rescale existing grades" to "Yes" and modify "Maximum Grade" (say 50)
      5. Press Save and display
      6. Follow Edit settings
      7. Ensure Grade is saved to 50
      8. Set "Rescale existing grades" to "No" and modify "Maximum Grade" (say 75)
      3. Update grade for graded activity (Repeat MDL-48634) with js disabled
      1. Repeat above case with JS disabled.
      2. Make sure the form is well checked.
      4. Run behat
      1. Run lib/form/tests/behat/modgrade_validation.feature
      Show
      1. Update grade for non-graded activity Create an assignment with: Grade Type = Point Maximum Grade = 100 Press Save and Display. Follow Edit settings and make sure Grade Type = Point Maximum Grade = 100 Set Maximum Grade = 50 and Press save and Display Follow Edit Settings again Make sure: Grade Type = Point Maximum Grade = 50 Set Grade Type = Scale Scale = Separate and Connected ways of knowing. Follow Edit Settings and make sure Grade Type = Scale Scale = Separate and Connected ways of knowing. 2. Update grade for graded activity (Repeat MDL-48634 ) with js enabled Create an assignment Grade Type = Point Maximum Grade = 100 Save grade for 1 or more students Follow Edit Settings and make sure You see notification "Some grades have already been awarded" under grade section Grade Type is disabled Maximum Grade is disabled. Set "Rescale existing grades" to "Yes" and modify "Maximum Grade" (say 50) Press Save and display Follow Edit settings Ensure Grade is saved to 50 Set "Rescale existing grades" to "No" and modify "Maximum Grade" (say 75) 3. Update grade for graded activity (Repeat MDL-48634 ) with js disabled Repeat above case with JS disabled. Make sure the form is well checked. 4. Run behat Run lib/form/tests/behat/modgrade_validation.feature
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-mdl-53300

      Description

      If a grade has been updated for assignment, and teacher tries to update the max grade, on the edit page modgrade_type is disabled and value will not be posted.

      So the check done to find if value is changed and modgrade_rescalegrades is empty will never happen and allow user to rescale.

      FYI: Above case is failing few Behat 3 upgrade scenarios as the value of disabled elements will not be submitted with form https://www.w3.org/TR/html401/interact/forms.html#h-17.12.1

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16