Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53323

Close session quickly on xhprof pages

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.13, 2.8.11, 2.9.5, 3.0.2, 3.1
    • Fix Version/s: 2.9.6, 3.0.4
    • Component/s: Performance
    • Labels:
    • Testing Instructions:
      Hide

      1. Ensure XHProf is installed.
      2. In Site Administration > Development > Profiling, ensure it's enabled.
      3. View some pages.
      4. Open the profile for a selected page by using the 'this script has been profiled' link.
      5. Open the profile by "Viewing profile details"
      6. Open the call graph in a new tab
      7. while the callgraph is still loading/generating, click a function name. They page should load and not block.
      (If the graph completes, generate another one to allow session lock testing)
      8. while the callgraph is generating, type in the box in the top right hand corner to find a function name.
      9. Load that function page while the callgraph is still running.
      10. Browse the moodle site while the call graph is loading.

      You can now use Moodle while the callgraph or other parts of XHProf are running.

      Show
      1. Ensure XHProf is installed. 2. In Site Administration > Development > Profiling, ensure it's enabled. 3. View some pages. 4. Open the profile for a selected page by using the 'this script has been profiled' link. 5. Open the profile by "Viewing profile details" 6. Open the call graph in a new tab 7. while the callgraph is still loading/generating, click a function name. They page should load and not block. (If the graph completes, generate another one to allow session lock testing) 8. while the callgraph is generating, type in the box in the top right hand corner to find a function name. 9. Load that function page while the callgraph is still running. 10. Browse the moodle site while the call graph is loading. You can now use Moodle while the callgraph or other parts of XHProf are running.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:

      Description

      When using xhprof, particularly the callgraph it can generate for 1 to 20 seconds. The session should be closed as early as possible to allow the user to either use the site or other parts of the xhprof application.

      This will speed up usage of the profiling tools.

        Attachments

          Activity

            People

            Assignee:
            mr-russ Russell Smith
            Reporter:
            mr-russ Russell Smith
            Peer reviewer:
            David Monllaó
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/May/16