Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53370

Core/str AMD module incorrect string param caching

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Deferred
    • Affects Version/s: 2.9.4
    • Fix Version/s: None
    • Component/s: JavaScript, Language
    • Labels:
      None
    • Testing Instructions:
      Hide
      • Install local_strtest plugin (local_strtest.zip attached)
      • Navigate to pageone.php and see the notification lang string contains the correct parameter value
      • Navigate to pagetwo.php and see the notification lang string contains the parameter value from the previous page (not the value passed to the module init() method)
      Show
      Install local_strtest plugin ( local_strtest.zip attached) Navigate to pageone.php and see the notification lang string contains the correct parameter value Navigate to pagetwo.php and see the notification lang string contains the parameter value from the previous page ( not the value passed to the module init() method)
    • Affected Branches:
      MOODLE_29_STABLE

      Description

      It seems that the param argument to 'core/str' get_string method isn't taken into account when caching in, and subsequent retrieval from, localstorage

      Attaching a simple local plugin that demonstrates the problem

        Attachments

        1. local_strtest.zip
          3 kB
        2. pageone.png
          pageone.png
          12 kB
        3. pagetwo.png
          pagetwo.png
          10 kB

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                pholden Paul Holden
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie, cameron1729, David Mudrák (@mudrd8mz), Helen Foster
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: