Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53381

Remove chained step usage in Moodle

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Run behat
      1. Ensure behat is passing on nightly.

      master only

      Ensure no chained steps are used in core.
      1. Check o/p of behat and make sure you don't see "Chained steps are deprecated. Use behat_base::execute_step() instead..."
      2. grep and ensure there is no Given/When/Then step used in any behat context.
      Check deprecation message:
      1. Checkout latest integration branch with this patch
      2. git fetch https://github.com/rajeshtaneja/moodle.git test-53381
      3. git cherry-pick c1fa21c329f6ac608f68879a76c668411079340c
      4. Run behat with mod/forum/tests/behat/add_forum.feature and ensure you get following message after the run is finished.

        Chained steps are deprecated. Use behat_base::execute_step() instead...
        

      Follow testing instruction of MDL-53624
      Show
      Run behat Ensure behat is passing on nightly. master only Ensure no chained steps are used in core. Check o/p of behat and make sure you don't see "Chained steps are deprecated. Use behat_base::execute_step() instead..." grep and ensure there is no Given/When/Then step used in any behat context. Check deprecation message: Checkout latest integration branch with this patch git fetch https://github.com/rajeshtaneja/moodle.git test-53381 git cherry-pick c1fa21c329f6ac608f68879a76c668411079340c Run behat with mod/forum/tests/behat/add_forum.feature and ensure you get following message after the run is finished. Chained steps are deprecated. Use behat_base::execute_step() instead... Follow testing instruction of MDL-53624
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      wip-mdl-53381

      Description

      Chained steps are not supported by Behat 3. With MDL-46891 getting in we should remove usage of chained steps and remove support for in in Moodle 3.x (to decide) release.

      This issue should fix following:

      1. Remove usage of chained steps in core
      2. Add notice at the end of execution if chained steps are used in any step.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Andrew Nicols
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16