Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53399

Remove 'activity chooser off/on' option

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Load up firebug (or the equivalent) and open the console to ensure you catch any JS errors that may occur.
      2. Login as admin or teacher.
      3. Go to a course (create one if it doesn't exist).
      4. Turn editing mode on.
      5. Ensure under 'Turn editing off' in the 'Course administration' you do not see 'Activity chooser off' or 'Activity chooser on'.
      6. Ensure you see 'Add an activity or resource' and clicking on that brings up the activity chooser pop-up.
      7. Add an activity to the course and ensure all is well.
      8. Visit your user preference page.
      9. Click on 'Course preferences'.
      10. Uncheck 'Enable activity chooser' and save changes.
      11. Go back to the course.
      12. Turn editing mode on if it isn't on.
      13. Ensure under 'Turn editing off' in the 'Course administration' you do not see 'Activity chooser off' or 'Activity chooser on'.
      14. Ensure that instead of the 'Add an activity or resource' text you see two drop-downs for resources and activities.
      Test 2
      1. Create a user.
      2. Enrol the user into a course as a teacher.
      3. Visit the user preference page for the teacher you enrolled.
      4. Click on 'Course preferences'.
      5. Uncheck 'Enable activity chooser' and save changes.
      6. Click on 'Course preferences'.
      7. Check that the setting remains unchecked.
      8. Log in as the teacher.
      9. Visit the course.
      10. Turn editing mode on.
      11. Check you see drop-down boxes to add resources/activities.
      12. Log in as the admin.
      13. Visit the user preference page for the teacher you enrolled.
      14. Click on 'Course preferences'.
      15. Check 'Enable activity chooser' and save changes.
      16. Click on 'Course preferences'.
      17. Check that the setting remains checked.
      18. Log in as the teacher.
      19. Visit the course.
      20. Turn editing mode on.
      21. Check that you see the text 'Add an activity or resource' which shows a pop-up when clicked.
      Test 3
      1. Put the attached 'deprecation.php' file in your wwwroot.
      2. Visit <yoursite>/deprecation.php and ensure you are shown the following debugging messages -

        String [modchooserenable,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation
         
        String [modchooserdisable,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation
         
        core_course_renderer::add_modchoosertoggle() is deprecated.
        

      Test 4
      1. Run the behat test user/tests/behat/course_preference.feature
      Show
      Test 1 Load up firebug (or the equivalent) and open the console to ensure you catch any JS errors that may occur. Login as admin or teacher. Go to a course (create one if it doesn't exist). Turn editing mode on. Ensure under 'Turn editing off' in the 'Course administration' you do not see 'Activity chooser off' or 'Activity chooser on'. Ensure you see 'Add an activity or resource' and clicking on that brings up the activity chooser pop-up. Add an activity to the course and ensure all is well. Visit your user preference page. Click on 'Course preferences'. Uncheck 'Enable activity chooser' and save changes. Go back to the course. Turn editing mode on if it isn't on. Ensure under 'Turn editing off' in the 'Course administration' you do not see 'Activity chooser off' or 'Activity chooser on'. Ensure that instead of the 'Add an activity or resource' text you see two drop-downs for resources and activities. Test 2 Create a user. Enrol the user into a course as a teacher. Visit the user preference page for the teacher you enrolled. Click on 'Course preferences'. Uncheck 'Enable activity chooser' and save changes. Click on 'Course preferences'. Check that the setting remains unchecked. Log in as the teacher. Visit the course. Turn editing mode on. Check you see drop-down boxes to add resources/activities. Log in as the admin. Visit the user preference page for the teacher you enrolled. Click on 'Course preferences'. Check 'Enable activity chooser' and save changes. Click on 'Course preferences'. Check that the setting remains checked. Log in as the teacher. Visit the course. Turn editing mode on. Check that you see the text 'Add an activity or resource' which shows a pop-up when clicked. Test 3 Put the attached 'deprecation.php' file in your wwwroot. Visit <yoursite>/deprecation.php and ensure you are shown the following debugging messages - String [modchooserenable,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation   String [modchooserdisable,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation   core_course_renderer::add_modchoosertoggle() is deprecated. Test 4 Run the behat test user/tests/behat/course_preference.feature
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-53399

      Description

      It's not commonly used. Why do we have this listed right under 'Course administration'? Are teachers going, "Hmm, today I feel like using the clunky old interface with 90's drop downs to add my activities - I am so glad I can do this on a whim in Moodle."?

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                15 Vote for this issue
                Watchers:
                24 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16