Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53433

Unclear what the Comment API 'client_id' allowed characters are

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: None
    • Component/s: Comments
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_31_STABLE

      Description

      When creating a new comment block, a client_id can be arbitrarily specified without needed for it be cleaned in any way, and no documentation on what characters are allowed. But, hyphens and underscores are trimmed when passed to comment_ajax.php.

      This issue should either allow those characters, or clarify that they are not allowed.

      Discovered in MDL-53347.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                fred Frédéric Massart
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: