Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53465

Upgrade PHPMailer to 5.2.14 for Moodle 3.1

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Setup email in your moodle instance
      2. Create some users with valid emails
      3. Do some actions that results in sending of emails (forgotten password, send message, etc.)
      4. Verify emails are received at the accounts specified in 2.

      Tip: If it fails, you can use email debugging to get messages from PHPMailer.

      • Please also check the third party library list at [Site administration  ► Development  ► Third party libraries] to ensure that the version number is correct.
      Show
      Setup email in your moodle instance Create some users with valid emails Do some actions that results in sending of emails (forgotten password, send message, etc.) Verify emails are received at the accounts specified in 2. Tip: If it fails, you can use email debugging to get messages from PHPMailer. Please also check the third party library list at [Site administration  ► Development  ► Third party libraries] to ensure that the version number is correct.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-53465-master
    • Sprint:
      3.1 Sprint 6
    • Sprint:
      3.1 Sprint 6

      Description

      5.2.14 was released on Nov 1, 2015
      https://github.com/PHPMailer/PHPMailer/releases

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            cibot CiBoT added a comment -

            Code verified against automated checks.

            Checked MDL-53465 using repository: git://github.com/abgreeve/moodle.git

            More information about this report

            Show
            cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-53465 using repository: git://github.com/abgreeve/moodle.git master (0 errors / 0 warnings) [branch: wip-MDL-53465-master | CI Job ] More information about this report
            Hide
            marina Marina Glancy added a comment -

            Check list for the library upgrade peer review:

            • library is updated
            • Unittests pass (check Travis results)
            • respective thirdpartylibs.xml is updated with the correct version
            • readme_moodle.txt is updated with the correct version and/or changes made
            • dev_docs_required label is added with a reminder to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated

            P.S. This is a message sent as part of bulk action to all open issues with libraries upgrade. This list applies to the majority of libraries however may be 100% correct for this particular issue

            Show
            marina Marina Glancy added a comment - Check list for the library upgrade peer review: library is updated Unittests pass (check Travis results) respective thirdpartylibs.xml is updated with the correct version readme_moodle.txt is updated with the correct version and/or changes made dev_docs_required label is added with a reminder to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated P.S. This is a message sent as part of bulk action to all open issues with libraries upgrade. This list applies to the majority of libraries however may be 100% correct for this particular issue
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Thanks Adrian,

            These changes look correct. Submitting for Integration

            Show
            dobedobedoh Andrew Nicols added a comment - Thanks Adrian, These changes look correct. Submitting for Integration
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            cibot CiBoT added a comment -

            Code verified against automated checks.

            Checked MDL-53465 using repository: git://github.com/abgreeve/moodle.git

            More information about this report

            Show
            cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-53465 using repository: git://github.com/abgreeve/moodle.git master (0 errors / 0 warnings) [branch: wip-MDL-53465-master | CI Job ] More information about this report
            Hide
            dmonllao David Monllaó added a comment -

            Thanks Adrian. Integrated to master. I was thinking of suggesting to add a note in lib/upgrade.txt about this change because of the changes noted in changelog.md but I'm not really sure... any opinion?

            Show
            dmonllao David Monllaó added a comment - Thanks Adrian. Integrated to master. I was thinking of suggesting to add a note in lib/upgrade.txt about this change because of the changes noted in changelog.md but I'm not really sure... any opinion?
            Hide
            dobedobedoh Andrew Nicols added a comment -

            David Monllaó, I felt that it wasn't necessary as we don't recommend direct access to phpmailer. Therefore any e-mail must come through email_to_user() and be subject to standard Moodle checks. Therefore I don't feel it's worth mentioning the IDN changes because we'd have to make sure that we support them all over Moodle first.
            The changes to POP3 shouldn't affect us particularly, and the SMTP Vulnerability should also be mitigated by ourselves

            Show
            dobedobedoh Andrew Nicols added a comment - David Monllaó , I felt that it wasn't necessary as we don't recommend direct access to phpmailer. Therefore any e-mail must come through email_to_user() and be subject to standard Moodle checks. Therefore I don't feel it's worth mentioning the IDN changes because we'd have to make sure that we support them all over Moodle first. The changes to POP3 shouldn't affect us particularly, and the SMTP Vulnerability should also be mitigated by ourselves
            Hide
            dmonllao David Monllaó added a comment -

            Show
            dmonllao David Monllaó added a comment -
            Hide
            fred Frédéric Massart added a comment -

            Passing, thanks.

            Show
            fred Frédéric Massart added a comment - Passing, thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And these delicious changes are now part of upstream Moodle, yay! Many, many thanks!

            There are two ways of constructing a software design: One way is
            to make it so simple that there are obviously no deficiencies, and the other way is
            to make it so complicated that there are no obvious deficiencies.
            The first method is far more difficult.
            – Tony Hoare

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And these delicious changes are now part of upstream Moodle, yay! Many, many thanks! There are two ways of constructing a software design: One way is to make it so simple that there are obviously no deficiencies, and the other way is to make it so complicated that there are no obvious deficiencies. The first method is far more difficult. – Tony Hoare
            Hide
            abgreeve Adrian Greeve added a comment -

            Removing dev_docs_required as I have updated the dev docs here.

            Show
            abgreeve Adrian Greeve added a comment - Removing dev_docs_required as I have updated the dev docs here .

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16