Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: None
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      On pages with the active HTML editor the following JS is placed behind the closing html tag = behind the end of the document. This is wrong and produces validator warnings. And probably leads to the incompatibility with other JS libraries. I couldn't test this because I did not find the place where the JS is generated.

      Probably high significance.

      </html>

      <script language=javascript type=text/javascript defer=defer>

      edit_summary = new HTMLArea('edit-summary');

      var config = edit_summary.config;

      config.pageStyle = body

      { background-color: #ffffff; font-family: Trebuchet MS,Verdana,Arial,Helvetica,sans-serif; }

      ;

      config.killWordOnPaste = true;

      config.fontname =

      { Trebuchet: 'Trebuchet MS,Verdana,Arial,Helvetica,sans-serif', Arial: 'arial,helvetica,sans-serif', Courier New: 'courier new,courier,monospace', Georgia: 'georgia,times new roman,times,serif', Tahoma: 'tahoma,arial,helvetica,sans-serif', Times New Roman: 'times new roman,times,serif', Verdana: 'verdana,arial,helvetica,sans-serif', Impact: 'impact', Wingdings: 'wingdings'}

      ;

      edit_summary.generate();

      </script>

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            From Janne Mikkonen (janne.mikkonen at julmajanne.com) Wednesday, 26 April 2006, 09:12 PM:

            use_html_editor function creates this code and it's usually called at the bottom of the page before printing footer like:

            if ( $usehtmleditor )

            { use_html_editor(); }

            print_footer($course);

            So it isn't actually editor bug but misusage of use_html_editor function.

            From Urs Hunkler (u.hunkler at elearningkontor.de) Wednesday, 26 April 2006, 11:04 PM:

            Thanks for your explanation Janne. I corrected the bug in course/edit.php and close this bug again.

            Show
            dougiamas Martin Dougiamas added a comment - From Janne Mikkonen (janne.mikkonen at julmajanne.com) Wednesday, 26 April 2006, 09:12 PM: use_html_editor function creates this code and it's usually called at the bottom of the page before printing footer like: if ( $usehtmleditor ) { use_html_editor(); } print_footer($course); So it isn't actually editor bug but misusage of use_html_editor function. From Urs Hunkler (u.hunkler at elearningkontor.de) Wednesday, 26 April 2006, 11:04 PM: Thanks for your explanation Janne. I corrected the bug in course/edit.php and close this bug again.
            Hide
            mblake Michael Blake added a comment -

            assign to a valid user

            Show
            mblake Michael Blake added a comment - assign to a valid user

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: