Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53475

Use new Flash messages and remove usage of continue_button

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: None
    • Component/s: Competencies
    • Labels:
    • Testing Instructions:
      Hide
      Behat
      1. Run mdk behat -r --tags @tool_lp
        • Confirm that there are no errors nor failures.
      Editing templates
      1. Go to Site administration ► Competencies ► Learning plans.
      2. Create a learning plan template.
      3. After saving the template, confirm that:
        • The page redirects to the template competencies page.
        • A Learning plan template created notification message is displayed
      4. Edit the learning plan template from the Learning plan templates page.
      5. After saving the template, confirm that:
        • The page redirects to the Learning plan templates page.
        • A Learning plan template updated notification message is displayed
      Editing plans
      1. Go to a user's profile and click on Learning plans.
      2. Create a learning plan.
      3. After saving the learning plan, confirm that:
        • The page redirects to the Learning plan page.
        • A Learning plan template created notification message is displayed
      4. Edit the learning plan by clicking on the gear icon beside the plan name.
      5. After saving the learning plan, confirm that:
        • The page redirects to the Learning plan page.
        • A Learning plan updated notification message is displayed
      6. Navigate to the user's list of learning plans.
      7. Edit the learning plan.
      8. After saving the learning plan, confirm that:
        • The page redirects to the Learning plans page.
        • A Learning plan updated notification message is displayed
      Evidence of prior learning
      1. Still on the Learning plans page, click on Evidence of prior learning
      2. Add a user evidence.
      3. After saving the user evidence, confirm that:
        • The page redirects to the Evidence page.
        • A Evidence of prior learning created notification message is displayed
      4. Edit the user evidence by clicking on the gear icon beside the plan name.
      5. After saving the user evidence, confirm that:
        • The page redirects to the user evidence page.
        • A Evidence of prior learning updated notification message is displayed
      6. Navigate to the user's Evidence of prior learning page.
      7. Edit the user evidence.
      8. After saving the Evidence, confirm that:
        • The page redirects to the Evidence of prior learning page page.
        • A Evidence of prior learning updated notification message is displayed
      Competencies
      1. Go to Site administration ► Competencies ► Competency Frameworks
      2. Create a competency framework and go click on it.
      3. Create a competency.
      4. After saving the competency, confirm that:
        • The page redirects to the framework competencies page.
        • A Competency created notification message is displayed
      5. Edit the competency.
      6. After saving the competency, confirm that:
        • The page redirects to the framework competencies page.
        • A Competency updated notification message is displayed
      Show
      Behat Run mdk behat -r --tags @tool_lp Confirm that there are no errors nor failures. Editing templates Go to Site administration ► Competencies ► Learning plans . Create a learning plan template. After saving the template, confirm that: The page redirects to the template competencies page. A Learning plan template created notification message is displayed Edit the learning plan template from the Learning plan templates page. After saving the template, confirm that: The page redirects to the Learning plan templates page. A Learning plan template updated notification message is displayed Editing plans Go to a user's profile and click on Learning plans . Create a learning plan. After saving the learning plan, confirm that: The page redirects to the Learning plan page. A Learning plan template created notification message is displayed Edit the learning plan by clicking on the gear icon beside the plan name. After saving the learning plan, confirm that: The page redirects to the Learning plan page. A Learning plan updated notification message is displayed Navigate to the user's list of learning plans. Edit the learning plan. After saving the learning plan, confirm that: The page redirects to the Learning plans page. A Learning plan updated notification message is displayed Evidence of prior learning Still on the Learning plans page, click on Evidence of prior learning Add a user evidence. After saving the user evidence, confirm that: The page redirects to the Evidence page. A Evidence of prior learning created notification message is displayed Edit the user evidence by clicking on the gear icon beside the plan name. After saving the user evidence, confirm that: The page redirects to the user evidence page. A Evidence of prior learning updated notification message is displayed Navigate to the user's Evidence of prior learning page. Edit the user evidence. After saving the Evidence, confirm that: The page redirects to the Evidence of prior learning page page. A Evidence of prior learning updated notification message is displayed Competencies Go to Site administration ► Competencies ► Competency Frameworks Create a competency framework and go click on it. Create a competency. After saving the competency, confirm that: The page redirects to the framework competencies page. A Competency created notification message is displayed Edit the competency. After saving the competency, confirm that: The page redirects to the framework competencies page. A Competency updated notification message is displayed
    • Affected Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-53475-master
    • Sprint:
      CBE Sprint 7

      Description

      There are a few pages where when a user has created/edited something a new page is displayed with only a small message and a continue button. Let's use the new notification system in master and display the message on the page where they are redirected to. You may need to change the redirection flow with this issue.

      Look at the APIs:

      • \core\notification::success()
      • redirect(2nd param, 4th param)

      Editing templates

      1. Use \core\notification (or just redirect()) to display the message on the next page
      2. Creating a new template redirects to the template competencies page
      3. Updating a template redirects back to where we came from, or the template competencies if unknown.

      Editing plans

      1. Use \core\notification (or just redirect()) to display the message on the next page
      2. Creating a new plan redirects to the newly created plan page
      3. Updating a plan redirects back to where we came from, or the udpated plan page if unknown.

      Evidence of prior learning

      1. Use \core\notification (or just redirect()) to display the message on the next page
      2. Creating a new evidence redirects to the newly created evidence
      3. Updating an evidence redirects back to where we came from, or the udpated evidence if unknown.

      Competencies

      1. Use \core\notification (or just redirect()) to display the message on the next page
      2. Creating a new competency redirects to the framework competencies
      3. Updating a competency redirects back to where we came from, or the list of framework competencies if unknown

      Competency frameworks

      1. Updating a framework redirects back to where we came from, or the udpated framework if unknown.
      2. Double check if the rest seems OK, but it should have been taken care of in MDL-53376

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Frédéric Massart
              Participants:
              Component watchers:
              Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: