Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53492

Use https://moodle.net instead of http://hub.moodle.org for registration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2, 3.2.4, 3.3.1
    • Fix Version/s: 3.2.5, 3.3.2
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      START BEFORE UPGRADE
      Use ngrok or similar to make your site visible from internet

      When testing on Master, you need to start with site version 3.3. After upgrade you will not be able to update your registration (see MDL-58694)

      1. Create a new Moodle site with STABLE version
      2. Go to Site Administration > Registration and register your site with moodle.org
      3. Create a course and publish it on moodle.net
      4. Create another course and advertise it on moodle.net
      5. UPGRADE TO INTEGRATION
      6. Go to Site administration > Registration and make sure your site is still registered and all registration info is correct
      7. Change something and update registration
      8. Go to Site administration > Server > Hubs and make sure you are registered with moodle.net
      9. Add "community finder" block somewhere and click on "Search"
      10. Make sure the URL under the moodle.net icon is https
      11. Make sure you can search for courses, install one of the courses
      12. Go to your published courses, select "Publish" from menu and make sure they are listed as published, update info (only available for advertised courses)
      13. remove course from hub
      14. publish the course again
      15. unregister your site on Site administration > Server > Hubs
      16. register the site again on Site administration > Registration
      17. unregister your site on Site administration > Server > Hubs
      Show
      START BEFORE UPGRADE Use ngrok or similar to make your site visible from internet When testing on Master, you need to start with site version 3.3. After upgrade you will not be able to update your registration (see MDL-58694 ) Create a new Moodle site with STABLE version Go to Site Administration > Registration and register your site with moodle.org Create a course and publish it on moodle.net Create another course and advertise it on moodle.net UPGRADE TO INTEGRATION Go to Site administration > Registration and make sure your site is still registered and all registration info is correct Change something and update registration Go to Site administration > Server > Hubs and make sure you are registered with moodle.net Add "community finder" block somewhere and click on "Search" Make sure the URL under the moodle.net icon is https Make sure you can search for courses, install one of the courses Go to your published courses, select "Publish" from menu and make sure they are listed as published, update info (only available for advertised courses) remove course from hub publish the course again unregister your site on Site administration > Server > Hubs register the site again on Site administration > Registration unregister your site on Site administration > Server > Hubs
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      wip-MDL-53492-master
    • Sprint:
      3.4 Sprint 3

      Description

      Original title: Moodle Registration Link Redirects to http in the URL

      When logged into Moodle as an administrator, under the Administration menu, clicking "Registration" will attempt to redirect to: ".../registration/register.php?huburl=http%3A%2F%2Fhub.moodle.org...". Unfortunately, in our environment we block http requests and don't yet automatically redirect http requests to https so this request gets blocked by our application firewall.

      This path looks like it is coming from the "HUB_MOODLEORGHUBURL" variable in moodlelib.php (line 493 on my version) where it is statically set as "http://hub.moodle.org". Can this be changed to https or even to just hub.moodle.org so that it is not forced to be one or the other?

      I noticed there was another variable being set specifically to http right above as well. It is the "HUB_HUBDIRECTORYURL" variable.

      edited: as a solution we register sites with https://moodle.net , this is the actual registration hub and http://hub.moodle.org is an alias that makes it compatible with older versions of Moodle.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17