Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53547

logstore_database_store_testcase makes false assumptions about database driver class names

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.5, 3.0.3, 3.1
    • Fix Version/s: 2.9.6, 3.0.4
    • Component/s: Logging, Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      This assumes you are set up to use Postgres.

      1. Save the two attached files inIn lib/dml
      2. Temporarily edit your config.php to say $CFG->dbtype = 'my_test';
        $CFG->dblibrary = 'native';
      3. Run phpunit logstore_database_store_testcase and verify that it passes.
      Show
      This assumes you are set up to use Postgres. Save the two attached files inIn lib/dml Temporarily edit your config.php to say $CFG->dbtype = 'my_test'; $CFG->dblibrary = 'native'; Run phpunit logstore_database_store_testcase and verify that it passes.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      If $CFG->dbtype contains an underscore (which it does for the OU custom driver class), then logstore_database_store_testcase fails.

      Fix coming up.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Mark Johnson Mark Johnson
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Rajesh Taneja Rajesh Taneja
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/May/16