[MDL-53547] logstore_database_store_testcase makes false assumptions about database driver class names - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

This assumes you are set up to use Postgres.

Save the two attached files inIn lib/dml

Temporarily edit your config.php to say $CFG->dbtype = 'my_test';
$CFG->dblibrary = 'native';

Run phpunit logstore_database_store_testcase and verify that it passes.
Show
This assumes you are set up to use Postgres. Save the two attached files inIn lib/dml Temporarily edit your config.php to say $CFG->dbtype = 'my_test'; $CFG->dblibrary = 'native'; Run phpunit logstore_database_store_testcase and verify that it passes.
Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-53547~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-53547

If $CFG->dbtype contains an underscore (which it does for the OU custom driver class), then logstore_database_store_testcase fails.

Fix coming up.