Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53548

Block show/hide links not keyboard accessible (again)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Click somewhere above a block to set focus (e.g. click in an edit field in the previous block).
      2. Press Tab to continue through focusable points in the block until you reach the show/hide button.

      EXPECTED: After the skip link, the next focusable item is the show/hide button
      BEFORE FIX: Before this fix the show/hide button cannot be focused and focus jumps to the dock button

      3. Press Return to activate the show/hide button
      EXPECTED: Block should hide, and focus should remain on the button (so you can press Return again to toggle).

      Show
      1. Click somewhere above a block to set focus (e.g. click in an edit field in the previous block). 2. Press Tab to continue through focusable points in the block until you reach the show/hide button. EXPECTED: After the skip link, the next focusable item is the show/hide button BEFORE FIX: Before this fix the show/hide button cannot be focused and focus jumps to the dock button 3. Press Return to activate the show/hide button EXPECTED: Block should hide, and focus should remain on the button (so you can press Return again to toggle).
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-53548-master

      Description

      Currently you cannot tab to the block show/hide buttons using keyboard; you can tab to the 'dock' button but not the show/hide one.

      The code for this was implemented in MDL-27197 but broken in MDL-49144 due to a case mistake in a property name (tabindex instead of tabIndex).

      As an additional bug, after fixing this part, the focus does not work properly - when you activate the button, focus disappears. It should focus the corresponding button i.e. if you selected 'hide' then the focus should be left on the 'show' button rather than on the now-disappeared hide button.

      I'll submit a patch that fixes these issues.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16