Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53557

Numeric questions in feedback does not allow partial boundaries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable mod_feedback
      2. Install language with another decimal separator (such as English or French)
      3. Create a feedback activity
      4. Add several numeric questions, some with min/max values, some without, some with partial
      5. Change the language and create numeric question with boundaries that have decimal separator
      6. Make sure all items are displayed on the edit form properly, for example (0-100), (minimum: 0), (maximum: 100) or no boundaries at all. When changing language the decimal point should change
      7. Answer the questions in the feedback in both English and non-English language, skip some answers, enter some with decimal separator
      8. As admin/manager view the "Responses" page, make sure all responses show correct values with the local decimal separator
      9. As admin/manager view the "Analyse" page, make sure all responses are correct and the average is correct
      10. Export analysis to Excel and make sure that all numbers are exported on both Sheets
      Show
      Enable mod_feedback Install language with another decimal separator (such as English or French) Create a feedback activity Add several numeric questions, some with min/max values, some without, some with partial Change the language and create numeric question with boundaries that have decimal separator Make sure all items are displayed on the edit form properly, for example (0-100), (minimum: 0), (maximum: 100) or no boundaries at all. When changing language the decimal point should change Answer the questions in the feedback in both English and non-English language, skip some answers, enter some with decimal separator As admin/manager view the "Responses" page, make sure all responses show correct values with the local decimal separator As admin/manager view the "Analyse" page, make sure all responses are correct and the average is correct Export analysis to Excel and make sure that all numbers are exported on both Sheets
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-MDL-53557-master

      Description

      By default when one create numeric question in feedback it has boundaries '-' for both minimum and maximum.
      I noticed in the code that '-' should be treated as no min (or no max), however it does not work.

      Also there is a missing string and there is logic duplicating core local number handling

        Attachments

          Activity

            People

            Assignee:
            marina Marina Glancy
            Reporter:
            marina Marina Glancy
            Peer reviewer:
            cameron1729
            Integrator:
            David Monllaó
            Tester:
            Andrew Nicols
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/May/16