Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53572

We should get rid of filter_mathjaxloader/httpurl and always load over https

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      A few combos to repeat before and after the patch, pay attention to http and https.

      1. BEFORE: Set your filter_mathjaxloader/httpsurl to something custom
      2. Upgrade moodle
      3. VERIFY: you don't get asked to choose the setting again
      4. VERIFY: the custom setting is still in place
      1. BEFORE: Set your filter_mathjaxloader/httpurl to something custom
      2. Upgrade moodle
      3. VERIFY: that after the upgrade you get prompted to choose the mathjax url
      1. BEFORE: leave mathjax settings as defaults
      2. upgrade moodle
      3. VERIFY: that no prompts are made for mathjax settings
      Show
      A few combos to repeat before and after the patch, pay attention to http and https. BEFORE: Set your filter_mathjaxloader/httpsurl to something custom Upgrade moodle VERIFY: you don't get asked to choose the setting again VERIFY: the custom setting is still in place BEFORE: Set your filter_mathjaxloader/httpurl to something custom Upgrade moodle VERIFY: that after the upgrade you get prompted to choose the mathjax url BEFORE: leave mathjax settings as defaults upgrade moodle VERIFY: that no prompts are made for mathjax settings
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-53572-master

      Description

      While discussing MDL-52752 with Adrian I realised that we should get rid of the http url setting. We should just use https in all cases.. see
      http://www.paulirish.com/2010/the-protocol-relative-url/

      This will simplify the settings also help with less work/maintenance when we upgrade.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Andrew Nicols
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16