Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53572

We should get rid of filter_mathjaxloader/httpurl and always load over https

    XMLWordPrintable

Details

    • MOODLE_30_STABLE
    • MOODLE_32_STABLE
    • MDL-53572-master
    • Hide

      A few combos to repeat before and after the patch, pay attention to http and https.

      1. BEFORE: Set your filter_mathjaxloader/httpsurl to something custom
      2. Upgrade moodle
      3. VERIFY: you don't get asked to choose the setting again
      4. VERIFY: the custom setting is still in place
      1. BEFORE: Set your filter_mathjaxloader/httpurl to something custom
      2. Upgrade moodle
      3. VERIFY: that after the upgrade you get prompted to choose the mathjax url
      1. BEFORE: leave mathjax settings as defaults
      2. upgrade moodle
      3. VERIFY: that no prompts are made for mathjax settings
      Show
      A few combos to repeat before and after the patch, pay attention to http and https. BEFORE: Set your filter_mathjaxloader/httpsurl to something custom Upgrade moodle VERIFY: you don't get asked to choose the setting again VERIFY: the custom setting is still in place BEFORE: Set your filter_mathjaxloader/httpurl to something custom Upgrade moodle VERIFY: that after the upgrade you get prompted to choose the mathjax url BEFORE: leave mathjax settings as defaults upgrade moodle VERIFY: that no prompts are made for mathjax settings

    Description

      While discussing MDL-52752 with Adrian I realised that we should get rid of the http url setting. We should just use https in all cases.. see
      http://www.paulirish.com/2010/the-protocol-relative-url/

      This will simplify the settings also help with less work/maintenance when we upgrade.

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59780 MathJax URL lost in upgrade

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-52752 Update MathJax to version 2.6

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46748 Mathjax default SSL CDN address is down causing atto to fail to load

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Adrian Greeve Adrian Greeve
              Andrew Lyons Andrew Lyons
              Mark Nelson Mark Nelson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16