Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53595

Update upgrade_stale_php_files_present() before 3.1 release

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      web

      1. Create and install a 3.0.x site.
      2. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist:
        • /lib/classes/log/sql_internal_reader.php
        • /mod/forum/pix/icon.gif
        • ...
      3. Do a web based upgrade to master.
      4. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      5. Delete the touched file and refresh.
      6. Ensure that the upgrade now will proceed.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      web Create and install a 3.0.x site. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist: /lib/classes/log/sql_internal_reader.php /mod/forum/pix/icon.gif ... Do a web based upgrade to master. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file and refresh. Ensure that the upgrade now will proceed. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D
      

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stronk7 Eloy Lafuente (stronk7)
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Simey Lameze
                Integrator:
                Dan Poltawski
                Tester:
                cameron1729
                Participants:
                Component watchers:
                Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16