Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53638

Convert feedback to use moodleform

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      I tried to cover as much as possible with behat. Here are some things that can not be tested by behat:

      1. Enable mod_feedback and block_feedback if not yet enabled
      2. Create a feedback in a course
      3. Edit the questions in the feedback module and add a label question with images in it
      4. Save the feedback module questions as a public template (in the "templates" tab)
      5. Login as a teacher from another course who does not have access to this course
      6. Create a feedback in your course
      7. Go to templates and try to use the template from above, make sure the images are displayed in the template preview
      8. Select to use this template
      9. Make sure the images appear in the edit form
      10. As a student complete the feedback and make sure images appear

      Visual test - make sure that things look reasonably good. Best way to do it is to have two sites 3.0 and master next to each other, perform all the following steps and make sure the pages in master looks better or the same as 3.0

      1. Create a feedback
      2. Edit questions, create questions with dependencies
      3. Preview feedback (click on magnifying glass next to the feedback name on the "Overview" page)
      4. Complete feedback
      5. View analysis
      6. Save feedback as a template
      7. Import from a template
      8. View respondents
      9. View individual responses
      10. View non-respondents (not available in feedbacks on frontpage)
      11. Map feedback to courses (not available in feedbacks in courses)

      Export:

      1. Create a feedback on course front page, make it non anonymous
      2. Add question of each type, including the captcha and information (course)
        • To add a captcha you need to configure a site here: https://www.google.com/recaptcha/admin
        • your moodle site will need to be accessible from the internet, so you might need to use a tool like ngrok
        • Once you've configured your site on google you need to add your site key and private key to the manage authentication admin page
          • site administration > plugins > authentication > manage authentication
      3. Add feedback block to several courses
      4. As students in the courses complete feedback by clicking on its name in the feedback block (this is imporant)
      5. As admin/manager go to analysis page and export responses
      6. Look at the xls file and make sure all data is present there
      Show
      I tried to cover as much as possible with behat. Here are some things that can not be tested by behat: Enable mod_feedback and block_feedback if not yet enabled Create a feedback in a course Edit the questions in the feedback module and add a label question with images in it Save the feedback module questions as a public template (in the "templates" tab) Login as a teacher from another course who does not have access to this course Create a feedback in your course Go to templates and try to use the template from above, make sure the images are displayed in the template preview Select to use this template Make sure the images appear in the edit form As a student complete the feedback and make sure images appear Visual test - make sure that things look reasonably good. Best way to do it is to have two sites 3.0 and master next to each other, perform all the following steps and make sure the pages in master looks better or the same as 3.0 Create a feedback Edit questions, create questions with dependencies Preview feedback (click on magnifying glass next to the feedback name on the "Overview" page) Complete feedback View analysis Save feedback as a template Import from a template View respondents View individual responses View non-respondents (not available in feedbacks on frontpage) Map feedback to courses (not available in feedbacks in courses) Export: Create a feedback on course front page, make it non anonymous Add question of each type, including the captcha and information (course) To add a captcha you need to configure a site here: https://www.google.com/recaptcha/admin your moodle site will need to be accessible from the internet, so you might need to use a tool like ngrok Once you've configured your site on google you need to add your site key and private key to the manage authentication admin page site administration > plugins > authentication > manage authentication Add feedback block to several courses As students in the courses complete feedback by clicking on its name in the feedback block (this is imporant) As admin/manager go to analysis page and export responses Look at the xls file and make sure all data is present there
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-MDL-53638-master

      Description

      This is a major overhaul of the feedback module

      • Moodleforms are used for completion, editing, previewing (print.php), viewing templates and viewing individual responses
      • Lots of feedback code is refactored and is easier to follow now
      • Resolves MDL-51930 - when a page contains only unavailable items it is skipped
      • The UI is also much better now

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16