Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53661

LTI - external tool - "Force SSL" setting will not save as unchecked once it is saved checked in a tool configuration

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. As an admin navigate to Site administration -> Plugins -> Activity modules -> LTI -> Manage external tool types
      2. Click "Add external tool configuration"
        1. Add any name, tool url (not relevant to this issue)
      3. Under the "Privacy" section check the "Force SSL" checkbox
      4. Click "Save changes"
      5. Edit the tool configuration you just created by clicking the settings icon
      6. Under the "Privacy" section uncheck the "Force SSL" checkbox
      7. Click "Save changes"
      8. Edit the tool configuration you just created by clicking the settings icon
      9. Verify the "Force SSL" checkbox is unchecked.
      Show
      As an admin navigate to Site administration -> Plugins -> Activity modules -> LTI -> Manage external tool types Click "Add external tool configuration" Add any name, tool url (not relevant to this issue) Under the "Privacy" section check the "Force SSL" checkbox Click "Save changes" Edit the tool configuration you just created by clicking the settings icon Under the "Privacy" section uncheck the "Force SSL" checkbox Click "Save changes" Edit the tool configuration you just created by clicking the settings icon Verify the "Force SSL" checkbox is unchecked.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53661_master

      Description

      If an LTI tool configuration has the forcessl setting checked and is saved, then if a user tries to edit the configuration and unset it when it is saved it does not stick.

      Steps to replicate:

      1. As an admin navigate to Site administration -> Plugins -> Activity modules -> LTI -> Manage external tool types
      2. Click "Add external tool configuration"
        1. Add any name, tool url (not relevant to this issue)
      3. Under the "Privacy" section check the "Force SSL" checkbox
      4. Click "Save changes"
      5. Edit the tool configuration you just created by clicking the settings icon
      6. Under the "Privacy" section uncheck the "Force SSL" checkbox
      7. Click "Save changes"
      8. Edit the tool configuration you just created by clicking the settings icon

      Result: The "Force SSL" setting will still be checked

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sbc24 Sam Chaffee
              Reporter:
              sbc24 Sam Chaffee
              Peer reviewer:
              cameron1729
              Integrator:
              Andrew Nicols
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16