Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53695

Replace mrclay/minify with matthiasmullie/minify

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0, 3.2
    • Fix Version/s: 3.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Use boost
      2. Set in your config:

        $CFG->cachejs = 1;
        $CFG->themedesignermode = 0;
        

      3. Inspect the css files included in Moodle pages, download them with curl (or something)
      4. VERIFY: That the files you downloaded are minified
      5. Inspect the js files included in Moodle pages which are NOT yui or amd modules (e.g. javascript-static.js) and download with curl
      6. VERIFY: the js files are minified
      7. purge caches
      8. Verify JS still works - no javascript errors detected in console
      9. Verify CSS did not change - the style looks the same
      10. Enable tinymce editor in your profile
      11. Go to a page with tinymce on and verify it works
      12. let cibot run lib/tests/minify_test.php
      Show
      Use boost Set in your config: $CFG->cachejs = 1; $CFG->themedesignermode = 0; Inspect the css files included in Moodle pages, download them with curl (or something) VERIFY: That the files you downloaded are minified Inspect the js files included in Moodle pages which are NOT yui or amd modules (e.g. javascript-static.js) and download with curl VERIFY: the js files are minified purge caches Verify JS still works - no javascript errors detected in console Verify CSS did not change - the style looks the same Enable tinymce editor in your profile Go to a page with tinymce on and verify it works let cibot run lib/tests/minify_test.php
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-53695-master

      Description

      The part of the minify library that we use has been deprecated so we should not upgrade it anymore. Instead we should find an alternative

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16