Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53765

Remove usage of deprecated function update_module_button()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.3
    • Fix Version/s: 3.2
    • Component/s: Resource, Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide
      Resource
      1. Upload a File resource and set display to Embed
      2. View File and verify that there isn't a button that says "Update this File"
      Wiki
      1. Create Wiki activity
      2. Create a wiki page and click Preview and verify that there isn't a button that says "Update this Wiki"
      Other tests
      1. Confirm that there is update_module_button() or core_renderer::update_module_button() are not being used anywhere in Moodle.
      2. Run Behat tests for mod_wiki and mod_resource.
        • Confirm that there are no errors nor failures.
      Show
      Resource Upload a File resource and set display to Embed View File and verify that there isn't a button that says "Update this File" Wiki Create Wiki activity Create a wiki page and click Preview and verify that there isn't a button that says "Update this Wiki" Other tests Confirm that there is update_module_button() or core_renderer::update_module_button() are not being used anywhere in Moodle. Run Behat tests for mod_wiki and mod_resource. Confirm that there are no errors nor failures.
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53765-master
    • Pull Master Diff URL:

      Description

      In MDL-21169, it was agreed to remove the "Update this <module>" from navigation. But because of legacy reasons some core plugins haven't been updated yet, such as Resource and Wiki.

      This patch will remove the call to update_module_button() and deletes the long standing deprecated function.

        Attachments

          Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55354 Properly deprecate update_module_button

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55354 Properly deprecate update_module_button

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-21169 Remove update module buttons from header once all modules extend settings block

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              rex Rex Lorenzo
              Peer reviewer:
              Marina Glancy
              Integrator:
              Dan Poltawski
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16