Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 3.1
Affects Version/s: 3.1
Component/s: Assignment
Labels:
- ci
- triaged

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
http://github.com/damyon/moodle
Pull Main Branch:
~~MDL-53841~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/MDL-53841-master~1...MDL-53841-master
Testing Instructions:

Hide

Add the activities block to a course. Click on assignments in the block. Verify there is no debugging. Click purge caches, verify you go back to the same page.

Show
Add the activities block to a course. Click on assignments in the block. Verify there is no debugging. Click purge caches, verify you go back to the same page.

~~MDL-52954~~ was integrated - but we hadn't waited for a full complete behat run. Now that the run is complete it looks like there were some failures:

http://integration.moodle.org/job/M.08%20Run%20all%20behat%20features%20in%20firefox-linux%20-%20Parallel/lastBuild/console

I see 2 errors here - one looks like it's from mod_feedback - and I'll ignore that one here. The other looks real and looks like this error repeated in several tests:

Notice: Trying to get property of non-object in /store/moodle/behat_whole_suite_m_parallel/mod/assign/locallib.php on line 208

      ' in /store/moodle/behat_whole_suite_m_parallel/lib/behat/behat_base.php:784

      Stack trace:

      #0 /store/moodle/behat_whole_suite_m_parallel/lib/tests/behat/behat_hooks.php(504): behat_base->look_for_exceptions()

      #1 [internal function]: behat_hooks->i_look_for_exceptions()

      #2 /store/moodle/behat_whole_suite_m_parallel/vendor/behat/behat/src/Behat/Testwork/Call/Handler/RuntimeCallHandler.php(104): call_user_func_array(Array, Array)

      #3 /store/moodle/behat_whole_suite_m_parallel/vendor/behat/behat/src/Behat/Testwork/Call/Handler/RuntimeCallHandler.php(60): Behat\Testwork\Call\Handler\RuntimeCallHandler->executeCall(Object(Behat\Behat\Definition\Call\DefinitionCall))

To reproduce - view the assignment overview page. /mod/assign/index.php?id=<courseid>

is a regression caused by

MDL-52954 Improvements to the Assignment grading user interface

Closed

Assignee:: Damyon Wiese

Reporter:: Damyon Wiese

Peer reviewer:: Simey Lameze

Integrator:: David Monllaó

Tester:: Adrian Greeve

Participants:: Adrian Greeve, CiBoT, Damyon Wiese, David Monllaó, Eloy Lafuente (stronk7), Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 18/Apr/16 6:00 AM

Updated:: 23/Apr/16 3:51 AM

Resolved:: 23/Apr/16 3:51 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify